This repository was archived by the owner on Mar 27, 2025. It is now read-only.
feat: Add generation of types, fix tests#8
Merged
kevaundray merged 2 commits intonoir-lang:masterfrom Aug 24, 2023
Merged
Conversation
3 tasks
kevaundray
reviewed
Aug 24, 2023
kevaundray
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extension for the package, allows to generate types declarations
Problem*
Mocha tests of crate
wasmfail on nodejs platform because the package provides no typings.It is a part of fix noir-lang/noir#2387
Summary*
Added types generation in building process. Committed types and updated
package.json.Additional Context
I fixed the tests because the tests fail.
PR Checklist*
cargo fmton default settings.