chore: Add `noir_wasm` testing workflow by jonybur · Pull Request #1921 · noir-lang/noir

jonybur · 2023-07-13T14:35:48Z

Description

Adds a workflow to test noir_wasm

Problem*

noir_wasm breaks and this should flag whenever it does (before we merge something that breaks it)

Resolves

Summary*

Simple workflow that adds an integration with https://github.com/noir-lang/noir-wasm-testing
It builds noir_wasm, takes the noir-wasm-testing repo and injects it - then it runs the test.

Documentation

This PR requires documentation updates when merged.
- I will submit a noir-lang/docs PR.
- I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

Savio-Sou · 2023-07-14T03:44:02Z

Is this related to / supersedes #1660?

jonybur · 2023-07-14T10:10:59Z

@Savio-Sou yes, it's updated to work with the wasm build workflow

…ng-workflow

…ing` (#2079) --------- Co-authored-by: jonybur <jobur93@gmail.com>

TomAFrench · 2023-08-04T14:22:17Z

Changing this to chore as it doesn't need to go in the changelog.

.github/workflows/wasm.yml

* master: (50 commits) chore: update stale comment on `create_circuit` (#2173) chore: Replace `resolve_path` function with a trait that impls normalize (#2157) chore: clippy fix (#2174) feat!: Allow specifying new package name with `--name` flag (#2144) chore!: remove unused flags on LSP command (#2170) chore: Hide the `show_ssa` and `show_brillig` flags (#2171) chore: bump `clap` to 4.3.19 (#2167) chore: Move the long line of `nargo info` to `long_about` (#2151) chore: Refactor `normalize_path` into an API on FileManager (#2156) fix: Implement slices of structs (#2150) chore: Refreshed ACIR artifacts (#2148) chore: Rebuild ACIR test artifacts (#2147) chore: remove short flags for `--show-ssa` and `--deny-warnings` (#2141) chore: replace usage of `Directive::Quotient` with brillig opcode (#1766) chore: clippy fix (#2136) feat: Initial work on rewriting closures to regular functions with hi… (#1959) chore: Decouple acir blockid from ssa valueid (#2103) chore: Initialize copy array from previous values in `array_set` (#2106) chore: rename `ssa_refactor` module to `ssa` (#2129) chore: Use `--show-output` flag on execution rather than compilation (#2116) ...

--------- Co-authored-by: jonybur <jobur93@gmail.com>

…into jb/noir-testing-workflow

TomAFrench

LGTM

* master: chore: Remove symlink and dummy config file (#2200) fix: Fix an ICE when reassigning a mutable lambda variable to one with a different environment type (#2172) feat: Only create new witnesses for distinctiveness when duplicates exist (#2191) chore: Use helper functions for getting values of `AcirVar`s (#2194) feat: Add support for slices of structs and nested slices in brillig (#2084) feat: Perform sorting of constant arrays at compile time (#2195) chore: Improve unary error (#2199) chore: separate integration test cases into directories based on expected result (#2198) chore: remove stale comment (#2197) feat(nargo): Support custom entry points specified in TOML (#2158) fix(nargo): Indicate which TOML file is missing package name (#2177) fix: remove duplicated `name` option in `nargo new` (#2183) chore: add documentation to the `nargo lsp` command (#2169) feat(nargo)!: Require package `type` be specified in Nargo.toml (#2134) fix(nargo): Make dependencies section optional in TOML (#2161) chore: Do not create new memory block when not needed (#2142) fix: fix an ICE happening when we call a closure result from if/else (#2146) chore: remove unnecessary cloning of package dependencies (#2175)

.github/workflows/wasm.yml

crates/wasm/noir-script/src/main.nr

crates/wasm/test/browser/index.test.ts

TomAFrench · 2023-08-07T17:33:40Z

@kevaundray @kobyhallx Could you force merge this once CI passes? I'm seeing a phantom CI workflow on this which is going to block this. It should be fine once it's in master however.

kevaundray · 2023-08-07T17:51:10Z

@kevaundray @kobyhallx Could you force merge this once CI passes? I'm seeing a phantom CI workflow on this which is going to block this. It should be fine once it's in master however.

Removed the required phantom CI workflow

* master: feat: Optimize equality checks between a boolean and constant (#2201) feat: Issue warning for signed integers (#2185) chore: Add `noir_wasm` testing workflow (#1921)

* master: (35 commits) feat: Issue warning for signed integers (#2185) chore: Add `noir_wasm` testing workflow (#1921) chore: Remove symlink and dummy config file (#2200) fix: Fix an ICE when reassigning a mutable lambda variable to one with a different environment type (#2172) feat: Only create new witnesses for distinctiveness when duplicates exist (#2191) chore: Use helper functions for getting values of `AcirVar`s (#2194) feat: Add support for slices of structs and nested slices in brillig (#2084) feat: Perform sorting of constant arrays at compile time (#2195) chore: Improve unary error (#2199) chore: separate integration test cases into directories based on expected result (#2198) chore: remove stale comment (#2197) feat(nargo): Support custom entry points specified in TOML (#2158) fix(nargo): Indicate which TOML file is missing package name (#2177) fix: remove duplicated `name` option in `nargo new` (#2183) chore: add documentation to the `nargo lsp` command (#2169) feat(nargo)!: Require package `type` be specified in Nargo.toml (#2134) fix(nargo): Make dependencies section optional in TOML (#2161) chore: Do not create new memory block when not needed (#2142) fix: fix an ICE happening when we call a closure result from if/else (#2146) chore: remove unnecessary cloning of package dependencies (#2175) ...

jonybur added 3 commits July 13, 2023 14:35

Edit workflow

3e9e46c

Output built directory

1e906d4

Fix noir_wasm copy

39a8434

jonybur added 3 commits July 14, 2023 10:34

Fix workflow

1d3d30e

Add mkdir to workflow

b71f94c

Merge branch 'master' of github.com:noir-lang/noir into jb/noir-testi…

e362da8

…ng-workflow

jonybur changed the title ~~(feat): add noir_wasm testing workflow~~ feat: add noir_wasm testing workflow Jul 24, 2023

jonybur changed the title ~~feat: add noir_wasm testing workflow~~ feat: Add noir_wasm testing workflow Jul 24, 2023

jonybur marked this pull request as ready for review July 24, 2023 13:57

Remove logs

7473ce7

TomAFrench self-requested a review July 27, 2023 17:35

Merge branch 'master' into jb/noir-testing-workflow

5029bad

TomAFrench mentioned this pull request Aug 4, 2023

chore: Ensure that CLI and wasm compilers are sync in noir_wasm_testing #2079

Merged

5 tasks

chore: Ensure that CLI and wasm compilers are sync in `noir_wasm_test…

4e0a050

…ing` (#2079) --------- Co-authored-by: jonybur <jobur93@gmail.com>

TomAFrench changed the title ~~feat: Add noir_wasm testing workflow~~ chore: Add noir_wasm testing workflow Aug 4, 2023

TomAFrench reviewed Aug 4, 2023

View reviewed changes

.github/workflows/wasm.yml Outdated Show resolved Hide resolved

TomAFrench and others added 11 commits August 4, 2023 15:26

Update .github/workflows/wasm.yml

6c320e1

chore: run browser tests rather than nodejs tests

e33058f

chore: fix test command in CI

99ba717

chore: bring noir-wasm-testing repo contents into wasm crate

778b095

--------- Co-authored-by: jonybur <jobur93@gmail.com>

chore: update compile command to handle not being at repo root

8a545c6

chore: remove unnecessary checkout

c31e681

chore: update location to look for nargo binary

f283748

chore: add missing $

bea37a1

chore: remove self-referential dependency

978551d

chore: switch to noir-lang/noir-source-resolver version which exists

9552903

jonybur and others added 9 commits August 7, 2023 14:54

Revisions

f4a94a9

Merge branch 'jb/noir-testing-workflow' of github.com:noir-lang/noir …

cdc4ab1

…into jb/noir-testing-workflow

chore: fix CI workflow

7eb2668

chore: remove usage of matrix.target

1dd0d58

chore: fix path to binary

ed04d05

chore: remove unwanted printing when compiling noir program

fc4571d

chore: update Nargo.toml to be compliant with new format

62b5947

chore: remove unnecessary checkout

98ed3fd

chore: add todo to workflow

b6eac52

TomAFrench previously approved these changes Aug 7, 2023

View reviewed changes

TomAFrench enabled auto-merge August 7, 2023 17:27

TomAFrench reviewed Aug 7, 2023

View reviewed changes

.github/workflows/wasm.yml Outdated Show resolved Hide resolved

Update .github/workflows/wasm.yml

8d1758f

TomAFrench dismissed their stale review via 8d1758f August 7, 2023 17:30

TomAFrench reviewed Aug 7, 2023

View reviewed changes

crates/wasm/noir-script/src/main.nr Outdated Show resolved Hide resolved

Update crates/wasm/noir-script/src/main.nr

5bba829

TomAFrench reviewed Aug 7, 2023

View reviewed changes

crates/wasm/test/browser/index.test.ts Outdated Show resolved Hide resolved

Update crates/wasm/test/browser/index.test.ts

6ae95f4

TomAFrench approved these changes Aug 7, 2023

View reviewed changes

kevaundray disabled auto-merge August 7, 2023 17:49

kevaundray added this pull request to the merge queue Aug 7, 2023

Merged via the queue into master with commit 08683e1 Aug 7, 2023

kevaundray deleted the jb/noir-testing-workflow branch August 7, 2023 18:08

Savio-Sou mentioned this pull request Aug 16, 2023

Noir-wasm nodeJs testing #2326

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add `noir_wasm` testing workflow#1921

chore: Add `noir_wasm` testing workflow#1921
kevaundray merged 34 commits intomasterfrom
jb/noir-testing-workflow

jonybur commented Jul 13, 2023 •

edited

Loading

Uh oh!

Savio-Sou commented Jul 14, 2023

Uh oh!

jonybur commented Jul 14, 2023

Uh oh!

TomAFrench commented Aug 4, 2023

Uh oh!

Uh oh!

TomAFrench left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Aug 7, 2023

Uh oh!

kevaundray commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jonybur commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Documentation

Additional Context

PR Checklist*

Uh oh!

Savio-Sou commented Jul 14, 2023

Uh oh!

jonybur commented Jul 14, 2023

Uh oh!

TomAFrench commented Aug 4, 2023

Uh oh!

Uh oh!

TomAFrench left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Aug 7, 2023

Uh oh!

kevaundray commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonybur commented Jul 13, 2023 •

edited

Loading