chore: better logic for checking whether an array index could have si…#11799
chore: better logic for checking whether an array index could have si…#11799TomAFrench merged 2 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 4d12c62 | Previous: 7214f72 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.068 s |
0.056 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 4d12c62 | Previous: 7214f72 | Ratio |
|---|---|---|---|
private-kernel-reset |
0.051 s |
0.042 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b6ab64a | Previous: 7214f72 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b6ab64a | Previous: 7214f72 | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
2.04 s |
1.69 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
2 participants
…de effects
Description
Problem
Follow-up to #11792
Summary
This is totally optional, but I find that in most cases it makes the output of
nargo expandmore reasonable. There's a tradeoff: we need to work (a bit) harder to determine whether we need a separate block of statements for the index. On the other hand, if we determine we don't need that block we can save a bit of memory. And I think doing this check should be pretty fast (it gets expressions from an Arena so it indexes directly into memory).Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.