Skip to content

chore: use stable lvalue index counter#11792

Merged
TomAFrench merged 2 commits intomasterfrom
ab/stable-lvalue-index-counter
Mar 6, 2026
Merged

chore: use stable lvalue index counter#11792
TomAFrench merged 2 commits intomasterfrom
ab/stable-lvalue-index-counter

Conversation

@asterite
Copy link
Collaborator

@asterite asterite commented Mar 5, 2026

Description

Problem

Resolves #11772

Summary

Additional Context

I'm still not totally sure why the index needs to be extracted to a temporary value. I'm sure there's a reason, but from looking at the code it looks like it will end up leading to the same result (in #8384 I couldn't find an explanation of why this is needed, other than it fixing the issue).

User Documentation

Check one:

  • No user documentation needed.
  • Changes in docs/ included in this PR.
  • [For Experimental Features] Changes in docs/ to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 9ece085 Previous: 8d63ab7 Ratio
test_report_zkpassport_noir_rsa_ 1 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 9ece085 Previous: 2cc42ad Ratio
rollup-block-root-single-tx 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: e8db7a0 Previous: 2cc42ad Ratio
private-kernel-tail 0.005 s 0.004 s 1.25

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite asterite requested a review from a team March 5, 2026 20:49
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should help greatly with external PRs!

@TomAFrench TomAFrench enabled auto-merge March 6, 2026 12:09
@TomAFrench TomAFrench added this pull request to the merge queue Mar 6, 2026
Merged via the queue into master with commit 43ef6a7 Mar 6, 2026
137 checks passed
@TomAFrench TomAFrench deleted the ab/stable-lvalue-index-counter branch March 6, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nargo expand format to not change when the stdlib is changed

3 participants