chore: use stable lvalue index counter#11792
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9ece085 | Previous: 8d63ab7 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9ece085 | Previous: 2cc42ad | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
0.003 s |
0.002 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: e8db7a0 | Previous: 2cc42ad | Ratio |
|---|---|---|---|
private-kernel-tail |
0.005 s |
0.004 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
jfecher
left a comment
There was a problem hiding this comment.
Thanks! This should help greatly with external PRs!
Description
Problem
Resolves #11772
Summary
Additional Context
I'm still not totally sure why the index needs to be extracted to a temporary value. I'm sure there's a reason, but from looking at the code it looks like it will end up leading to the same result (in #8384 I couldn't find an explanation of why this is needed, other than it fixing the issue).
User Documentation
Check one:
PR Checklist
cargo fmton default settings.