chore: enforce clippy::semicolon_if_nothing_returned linting rule#1139
Merged
kevaundray merged 2 commits intomasterfrom Apr 12, 2023
Merged
chore: enforce clippy::semicolon_if_nothing_returned linting rule#1139kevaundray merged 2 commits intomasterfrom
clippy::semicolon_if_nothing_returned linting rule#1139kevaundray merged 2 commits intomasterfrom
Conversation
kevaundray
approved these changes
Apr 12, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 13, 2023
* master: feat(nargo)!: define preprocessed artifacts for programs/contracts (#1126) feat: import core logic in cli from `nargo` crate (#1142) chore: enforce `clippy::semicolon_if_nothing_returned` linting rule (#1139) chore: borrow instead of cloning witness vectors in IR gen (#1127) fix: compiler identifying imported functions as being part of a contract (#1112) feat: Add new `Vec` type to frontend (#1103)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
This PR is a noop. I quite like the visual cue that semicolons give that nothing is being returned, but we're currently inconsistent on this with a mix of including vs omitting these semicolons. I've added a lint to standardise this and addressed any instances of missing semicolons.
https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context