feat: Add new Vec type to frontend#1103
Merged
kevaundray merged 4 commits intomasterfrom Apr 6, 2023
Merged
Conversation
added 2 commits
April 5, 2023 09:24
jfecher
changed the title
Vec type to frontendVec type to frontend
kevaundray
reviewed
Apr 6, 2023
kevaundray
reviewed
Apr 6, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Just one comment on documenting the stdlib methods!
TomAFrench
reviewed
Apr 6, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
kevaundray
approved these changes
Apr 6, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 13, 2023
* master: feat(nargo)!: define preprocessed artifacts for programs/contracts (#1126) feat: import core logic in cli from `nargo` crate (#1142) chore: enforce `clippy::semicolon_if_nothing_returned` linting rule (#1139) chore: borrow instead of cloning witness vectors in IR gen (#1127) fix: compiler identifying imported functions as being part of a contract (#1112) feat: Add new `Vec` type to frontend (#1103)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
Adds a
Vectype to the frontend, along with three unimplemented method stubs for the new builtinsvec_get,vec_push, andvec_pop. The type expects 1 generic argument as inVec<Field>, and similar to arrays it has the restriction of not allowing nested arrays currently.This type is currently not able to be constructed at all as no constructor is provided for the type. We should expose one once we get the internals and methods working for this type.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context