Skip to content

fix: clarify predicate comment in BrilligCall and Call opcodes #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 3 commits into from
Nov 6, 2025
Merged

fix: clarify predicate comment in BrilligCall and Call opcodes #10356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09b9a6d
Update opcodes.rs
DeVikingMark Nov 4, 2025
5f34eb2
Merge branch 'master' into fix/10350-predicate-comment
jfecher Nov 5, 2025
d858fcb
Merge branch 'master' into fix/10350-predicate-comment
DeVikingMark Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions acvm-repo/acir/src/circuit/opcodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ pub enum Opcode<F: AcirField> {
inputs: Vec<BrilligInputs<F>>,
/// Outputs to the function call
outputs: Vec<BrilligOutputs>,
/// Predicate of the Brillig execution - indicates if it should be skipped
/// Predicate of the Brillig execution - when the predicate evaluates to 0, execution is skipped.
/// When the predicate evaluates to 1 or is None, execution proceeds.
predicate: Option<Expression<F>>,
},

Expand All @@ -141,7 +142,8 @@ pub enum Opcode<F: AcirField> {
inputs: Vec<Witness>,
/// Outputs of the function call
outputs: Vec<Witness>,
/// Predicate of the circuit execution - indicates if it should be skipped
/// Predicate of the circuit execution - when the predicate evaluates to 0, execution is skipped.
/// When the predicate evaluates to 1 or is None, execution proceeds.
predicate: Option<Expression<F>>,
},
}
Expand Down
Loading