fix: clarify predicate comment in BrilligCall and Call opcodes#10356
Merged
jfecher merged 3 commits intonoir-lang:masterfrom Nov 6, 2025
Merged
fix: clarify predicate comment in BrilligCall and Call opcodes#10356jfecher merged 3 commits intonoir-lang:masterfrom
jfecher merged 3 commits intonoir-lang:masterfrom
Conversation
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 10, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(elaborator): Infer type of lambdas in tuple args; more docs (noir-lang/noir#10405) fix: revert "feat(ACIR): reuse element_type_sizes blocks with the same str… (noir-lang/noir#10428) chore(frontend): Avoid silent fallback when returning turbofish generics for primitive types (noir-lang/noir#10416) fix: mark ECDSA verification as `PureWithPredicate` (noir-lang/noir#10423) fix(parser): don't crash on incomplete type alias (noir-lang/noir#10421) chore(github): Refine pull request template wording (noir-lang/noir#10418) chore: refactor codegen_memory (noir-lang/noir#10323) chore(frontend): Primitive types generic count unit tests (noir-lang/noir#10412) chore: use SignedField::from_signed in enums.rs (noir-lang/noir#10408) chore: use `map_data_bus_in_place` in mem2reg (noir-lang/noir#10407) chore: apply typo fixes from Cantina (noir-lang/noir#10406) chore(frontend): Various comptime blocks unit tests (noir-lang/noir#10398) fix: clarify predicate comment in BrilligCall and Call opcodes (noir-lang/noir#10356) END_COMMIT_OVERRIDE
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 10, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(elaborator): Infer type of lambdas in tuple args; more docs (noir-lang/noir#10405) fix: revert "feat(ACIR): reuse element_type_sizes blocks with the same str… (noir-lang/noir#10428) chore(frontend): Avoid silent fallback when returning turbofish generics for primitive types (noir-lang/noir#10416) fix: mark ECDSA verification as `PureWithPredicate` (noir-lang/noir#10423) fix(parser): don't crash on incomplete type alias (noir-lang/noir#10421) chore(github): Refine pull request template wording (noir-lang/noir#10418) chore: refactor codegen_memory (noir-lang/noir#10323) chore(frontend): Primitive types generic count unit tests (noir-lang/noir#10412) chore: use SignedField::from_signed in enums.rs (noir-lang/noir#10408) chore: use `map_data_bus_in_place` in mem2reg (noir-lang/noir#10407) chore: apply typo fixes from Cantina (noir-lang/noir#10406) chore(frontend): Various comptime blocks unit tests (noir-lang/noir#10398) fix: clarify predicate comment in BrilligCall and Call opcodes (noir-lang/noir#10356) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10350
Clarifies the predicate documentation to explicitly state: