Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

chore(acir)!: Remove unused Directive opcodes#510

Merged
kevaundray merged 6 commits intomasterfrom
remove-unused-opcodes
Aug 30, 2023
Merged

chore(acir)!: Remove unused Directive opcodes#510
kevaundray merged 6 commits intomasterfrom
remove-unused-opcodes

Conversation

@TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Aug 30, 2023

Description

Problem*

Resolves #500

Summary*

This PR removes all the unused directives. The ones remaining are either used in Noir or in the ACVM stdlib.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kevaundray August 30, 2023 15:09
@TomAFrench
Merge branch 'master' into remove-unused-opcodes
1470b5b 
* master:
  feat(acir)!: Add predicate to MemoryOp (#503)
  chore(acvm)!: Remove unused arguments from `Backend` trait (#511)
  feat!: Assertion messages embedded in the circuit (#484)
@TomAFrench
chore: didn't commit new serialisation
72f0c99
@TomAFrench
Copy link
Member Author

TomAFrench commented Aug 30, 2023

@kevaundray We should merge this before updating barretenberg.

@kevaundray kevaundray added this pull request to the merge queue Aug 30, 2023
Merged via the queue into master with commit cfd8cbf Aug 30, 2023
@TomAFrench TomAFrench deleted the remove-unused-opcodes branch August 30, 2023 22:11
@kevaundray kevaundray mentioned this pull request Aug 30, 2023
Merged
Sakapoi pushed a commit to Sakapoi/acvm_fork that referenced this pull request Aug 31, 2023
@TomAFrench @Sakapoi
chore(acir)!: Remove unused Directive opcodes (noir-lang#510)
b1b225c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kevaundray kevaundray kevaundray approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomAFrench @kevaundray