This repository was archived by the owner on Apr 9, 2024. It is now read-only.
chore: Remove unused Directive::Log#500
Closed
Ethan-000 wants to merge 3 commits intoremove-unused-opcodesfrom
Closed
chore: Remove unused Directive::Log#500Ethan-000 wants to merge 3 commits intoremove-unused-opcodesfrom
Ethan-000 wants to merge 3 commits intoremove-unused-opcodesfrom
Conversation
TomAFrench
suggested changes
Aug 18, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
This breaks the serialization of Circuit. I'd like to perform all of these removals in one go to avoid the need for updating barretenberg multiple times.
10 tasks
Contributor
Author
|
i tried to updated serialization in barretenberg in this pr let me know if theres other parts of the code that need to be changed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
noir-lang/noir#2358 (comment)
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.