Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

chore!: Remove backend solvable opcodes from PWG trait #289

Merged
kevaundray merged 1 commit into from
May 18, 2023
Merged

chore!: Remove backend solvable opcodes from PWG trait #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 1 addition & 120 deletions acvm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,37 +67,7 @@ pub trait PartialWitnessGenerator {
inputs: &[FunctionInput],
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn and(
&self,
initial_witness: &mut WitnessMap,
lhs: &FunctionInput,
rhs: &FunctionInput,
output: &Witness,
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn xor(
&self,
initial_witness: &mut WitnessMap,
lhs: &FunctionInput,
rhs: &FunctionInput,
output: &Witness,
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn range(
&self,
initial_witness: &mut WitnessMap,
input: &FunctionInput,
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn sha256(
&self,
initial_witness: &mut WitnessMap,
inputs: &[FunctionInput],
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn blake2s(
&self,
initial_witness: &mut WitnessMap,
inputs: &[FunctionInput],
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;

fn compute_merkle_root(
&self,
initial_witness: &mut WitnessMap,
Expand All @@ -121,33 +91,12 @@ pub trait PartialWitnessGenerator {
inputs: &[FunctionInput],
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn hash_to_field_128_security(
&self,
initial_witness: &mut WitnessMap,
inputs: &[FunctionInput],
outputs: &Witness,
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn ecdsa_secp256k1(
&self,
initial_witness: &mut WitnessMap,
public_key_x: &[FunctionInput],
public_key_y: &[FunctionInput],
signature: &[FunctionInput],
message: &[FunctionInput],
outputs: &Witness,
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn fixed_base_scalar_mul(
&self,
initial_witness: &mut WitnessMap,
input: &FunctionInput,
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
fn keccak256(
&self,
initial_witness: &mut WitnessMap,
inputs: &[FunctionInput],
outputs: &[Witness],
) -> Result<pwg::OpcodeResolution, OpcodeResolutionError>;
}

pub trait SmartContract {
Expand Down Expand Up @@ -291,47 +240,6 @@ mod test {
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn and(
&self,
_initial_witness: &mut WitnessMap,
_lhs: &FunctionInput,
_rhs: &FunctionInput,
_output: &Witness,
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn xor(
&self,
_initial_witness: &mut WitnessMap,
_lhs: &FunctionInput,
_rhs: &FunctionInput,
_output: &Witness,
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn range(
&self,
_initial_witness: &mut WitnessMap,
_input: &FunctionInput,
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn sha256(
&self,
_initial_witness: &mut WitnessMap,
_inputs: &[FunctionInput],
_outputs: &[Witness],
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn blake2s(
&self,
_initial_witness: &mut WitnessMap,
_inputs: &[FunctionInput],
_outputs: &[Witness],
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn compute_merkle_root(
&self,
_initial_witness: &mut WitnessMap,
Expand Down Expand Up @@ -361,25 +269,6 @@ mod test {
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn hash_to_field_128_security(
&self,
_initial_witness: &mut WitnessMap,
_inputs: &[FunctionInput],
_output: &Witness,
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn ecdsa_secp256k1(
&self,
_initial_witness: &mut WitnessMap,
_public_key_x: &[FunctionInput],
_public_key_y: &[FunctionInput],
_signature: &[FunctionInput],
_message: &[FunctionInput],
_output: &Witness,
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn fixed_base_scalar_mul(
&self,
_initial_witness: &mut WitnessMap,
Expand All @@ -388,14 +277,6 @@ mod test {
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
fn keccak256(
&self,
_initial_witness: &mut WitnessMap,
_inputs: &[FunctionInput],
_outputs: &[Witness],
) -> Result<OpcodeResolution, OpcodeResolutionError> {
panic!("Path not trodden by this test")
}
}

#[test]
Expand Down