Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

chore!: Remove backend solvable opcodes from PWG trait#289

Merged
kevaundray merged 1 commit intogd/acvm_solvefrom
kw/rm-from-pwg-trait
May 18, 2023
Merged

chore!: Remove backend solvable opcodes from PWG trait#289
kevaundray merged 1 commit intogd/acvm_solvefrom
kw/rm-from-pwg-trait

Conversation

@kevaundray
Copy link
Copy Markdown
Contributor

@kevaundray kevaundray commented May 17, 2023

Related issue(s)

Continuation of #264 -- Since the bakends are no longer solving particular opcodes, we can remove them from the PWG trait

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

Summary of changes

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@kevaundray kevaundray changed the base branch from master to gd/acvm_solve May 18, 2023 19:28
@kevaundray kevaundray marked this pull request as ready for review May 18, 2023 19:28
@kevaundray kevaundray merged commit 779bfdb into gd/acvm_solve May 18, 2023
kevaundray added a commit that referenced this pull request May 18, 2023
@guipublic @kevaundray
feat!: Remove backend solvable methods from the interface and solve t…
69916cb 
…hem in ACVM (#264)

* Use acvm to solve bb functions when possible

* use backend for aes

* code review

* format

* Remove backend solvable opcodes from the PWG trait (#289)

* reduce diff

* revert merge overwrite

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@TomAFrench TomAFrench deleted the kw/rm-from-pwg-trait branch May 19, 2023 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kevaundray