This repository was archived by the owner on Apr 9, 2024. It is now read-only.
chore!: allow backends to specify support for all opcode variants#273
Merged
TomAFrench merged 13 commits intomasterfrom May 16, 2023
Merged
chore!: allow backends to specify support for all opcode variants#273TomAFrench merged 13 commits intomasterfrom
TomAFrench merged 13 commits intomasterfrom
Conversation
Contributor
Author
|
@TomAFrench See the diff for adding Fn trait |
phated
reviewed
May 9, 2023
TomAFrench
force-pushed
the
kw/add-fn-trait-is-supported
branch
from
f0c7140 to
65090f2
Compare
phated
reviewed
May 10, 2023
TomAFrench
reviewed
May 11, 2023
TomAFrench
reviewed
May 12, 2023
TomAFrench
approved these changes
May 12, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
I think this is good to merge at this point. Some nits I don't feel too strongly about.
5 tasks
1 task
Member
|
I touched this last so will let one of you two have the last word before merging. |
TomAFrench
changed the title
TomAFrench
changed the title
6 tasks
Merged
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: chore!: allow backends to specify support for all opcode variants (#273)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #258
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)