Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

chore!: backend can specify which opcode they support#258

Closed
guipublic wants to merge 1 commit intomasterfrom
gd/opcode_supported
Closed

chore!: backend can specify which opcode they support#258
guipublic wants to merge 1 commit intomasterfrom
gd/opcode_supported

Conversation

@guipublic
Copy link
Copy Markdown
Contributor

Description

Summary of changes

replace blackbox_supported with opcode_supported

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

This is useful for memory opcodes, we could have a TP backend which supports only ROM opcode for instance.

@TomAFrench
Copy link
Copy Markdown
Member

Can you address the other point in #183 in this PR?

@guipublic
Copy link
Copy Markdown
Contributor Author

Can you address the other point in #183 in this PR?

I was addressing them directly in #183

@TomAFrench
Copy link
Copy Markdown
Member

Sorry I don't follow, can you clarify what you mean? This PR as it is won't allow us to pass backend.opcode_supported into acvm::compile

@guipublic
Copy link
Copy Markdown
Contributor Author

Sorry I don't follow, can you clarify what you mean? This PR as it is won't allow us to pass backend.opcode_supported into acvm::compile

My bad, I thought you were talking about PR 153 on aztec backend (not the same repo and even not the same number...), sorry for the confusion.
I will look at the issue 183.

@TomAFrench
Copy link
Copy Markdown
Member

Closing in favour of #273

@TomAFrench TomAFrench closed this May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants