This repository was archived by the owner on Oct 31, 2023. It is now read-only.
chore: Remove sled & tempfile dev-dependencies#190
Merged
TomAFrench merged 2 commits intomasterfrom May 17, 2023
Merged
Conversation
phated
force-pushed
the
phated/remove-sled-tmpfile
branch
from
f9c7bdc to
809e670
Compare
TomAFrench
changed the title
sled & tempfile dev-dependencies
TomAFrench
approved these changes
May 17, 2023
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <tom@tomfren.ch>
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: chore: Remove `sled` & `tempfile` dev-dependencies (#190)
TomAFrench
added a commit
that referenced
this pull request
May 19, 2023
* feat!: update to target acvm-84b5d18d * chore: update to use new black box solver interface * use patch syntax * update to latest changes * feat!: update to acvm with non-homogeneous bb calls (#169) * feat: update acvm * feat!: updated acvm to latest master * chore: update cargo toml * Update src/barretenberg_structures.rs Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> * fix bad rebase * feat!: Update backend to rely on WitnessMap (#152) Co-authored-by: Tom French <tom@tomfren.ch> * update acvm * feat!: Implement CommonReferenceString trait (#139) * chore!: Remove filesystem access and utilize async fetch with range requests Co-authored-by: Tom French <tom@tomfren.ch> * chore: Switch to tokio test macro for async function (#191) * chore: Remove `sled` & `tempfile` dev-dependencies (#190) * chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <tom@tomfren.ch> * chore: bump to crates.io release * Update src/crs.rs * chore: Remove streaming CRS download & indicator (#194) * Update src/acvm_interop/common_reference_string.rs * code review --------- Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
sledandtempfilefrom the merkle tests. By removing these file-based dependencies from the test infrastructure, we'll need less separation between between wasm32 target tests and native tests.I'm not sure why the file-based dependencies were used, but it seems that the tests can be done with in-memory BTreeMaps.
Tests are passing, but need a review to make sure I didn't mess something up which makes them always pass 😛