This repository was archived by the owner on Oct 31, 2023. It is now read-only.
feat!: Update to acvm 0.12.0#165
Merged
Merged
Conversation
Merged
5 tasks
phated
reviewed
May 8, 2023
5 tasks
Contributor
|
I rebased this because I need it as a basis on my CRS changes that'll land in 0.12 |
Member
Author
|
Yep, I'm happy for anyone to update this to target the ACVM master as needed. |
* feat: update acvm * feat!: updated acvm to latest master * chore: update cargo toml * Update src/barretenberg_structures.rs Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
* chore!: Remove filesystem access and utilize async fetch with range requests Co-authored-by: Tom French <tom@tomfren.ch>
This was
linked to
issues
May 16, 2023
* chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <tom@tomfren.ch>
* master: chore: Remove `sled` & `tempfile` dev-dependencies (#190)
Contributor
|
This can now be updated to target 0.12 on crates.io |
phated
reviewed
May 17, 2023
Contributor
|
A lot of folks have touched this, so I'm going to request reviews from folks that haven't (such as @kevaundray @kobyhallx and @vezenovm) |
vezenovm
reviewed
May 17, 2023
Collaborator
vezenovm
left a comment
vezenovm
left a comment
There was a problem hiding this comment.
A couple minor comments. Not really familiar with the nix stuff so I defer to @phated and @kobyhallx on that
6 tasks
kevaundray
approved these changes
May 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the ACVM dependency to current master of ACVM.
This has shown an unfortunate effect of noir-lang/acvm#257 as we need to reconstruct the
BlackBoxFuncCallwhich gets deconstructed in ACVM in order to call back into the solver functions.