Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize cmake file and add tests #29

Merged
merged 2 commits into from
Oct 13, 2019
Merged

reorganize cmake file and add tests #29

merged 2 commits into from
Oct 13, 2019

Conversation

cjihrig
Copy link
Collaborator

@cjihrig cjihrig commented Oct 13, 2019

No description provided.

@cjihrig
reorganize cmake file and add tests
e8146cf
@cjihrig
build: split up "build it" CI step
64ec623 
This is supposed to make the CI work as intended on Windows.
@cjihrig cjihrig mentioned this pull request Oct 13, 2019
Merged
@gengjiawen
Copy link
Member

Should we merge this and #27 for quick iteration ?

@gengjiawen
Copy link
Member

I tried this patch with clion. I can debug single test very easily. Nice work 👍 .

gengjiawen
gengjiawen reviewed Oct 13, 2019
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Fix #10 ?

@cjihrig
Copy link
Collaborator Author

cjihrig commented Oct 13, 2019

Should we merge this and #27 for quick iteration ?

Yes, I'm going to land this now. Thanks for the review.

Add Fix #10 ?

I'm not sure that I want to close that issue yet. I'll update it to mention we need more tests.

@cjihrig cjihrig merged commit 64ec623 into master Oct 13, 2019
@cjihrig cjihrig deleted the make-test branch October 13, 2019 12:54
@cjihrig cjihrig mentioned this pull request Oct 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjihrig @gengjiawen