Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #10

Open
cjihrig opened this issue Oct 2, 2019 · 6 comments
Open

Add more tests #10

cjihrig opened this issue Oct 2, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@cjihrig
Copy link
Collaborator

cjihrig commented Oct 2, 2019

Right now, all of the "tests" are in app.c, which was originally supposed to be an example application using uvwasi. It would be great to split this up into proper tests.

@danbev
Copy link
Contributor

danbev commented Oct 2, 2019

@cjihrig Is there any special testing framework that should be used for this?

@cjihrig
Copy link
Collaborator Author

cjihrig commented Oct 2, 2019

Good question. I'm not really up to speed on C testing frameworks, so I can't say I have a preference. My primary requests would be something that isn't a maintenance burden and is easy to add and remove tests.

@danbev
Copy link
Contributor

danbev commented Oct 2, 2019

I've used CUnit a little, I could create a PR and see what you think?

@cjihrig
Copy link
Collaborator Author

cjihrig commented Oct 2, 2019

That would be great! From some quick googling, it doesn't look bad. Do you know if it supports Windows and all/most of the platforms where libuv runs?

@danbev
Copy link
Contributor

danbev commented Oct 3, 2019

Do you know if it supports Windows and all/most of the platforms where libuv runs?

I checked and it looks like Windows support is missing 😞 . I'll search a little more tomorrow and see if what I can find. I think that Check supports Windows so that might be an option.

@cjihrig
Copy link
Collaborator Author

cjihrig commented Oct 13, 2019

Since we moved to cmake, I added some tests using cmake's built in functionality in #29.

To anyone that might read this: we still need more tests though (which is why I'm leaving this open).

@cjihrig cjihrig changed the title Add proper tests Add more tests Oct 13, 2019
@cjihrig cjihrig added the help wanted Extra attention is needed label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants