Revert "Use --without-ffi on riscv64 (#236)"#237
Merged
Conversation
This reverts commit 27d048e.
Member
Author
|
Fixes #235 |
Member
Author
|
Confirmed OK in https://ci.nodejs.org/job/node-test-riscv64-experimental/70/ |
richardlau
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 27d048e.
The upstream FFI change has backported into node in nodejs/node#63794 so
libffican be re-enabled.This PR should not be merged until the that one has gone in, hence draft for now but reviews welcome.