Use --without-ffi on riscv64#236
Merged
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Member
Author
|
Note for reviewers that it is hoped this will be temporary and that the upstream libffi PR (also referenced in the upstrearelated issue) will resolve this at which point we can float it back. I could submit a patch to the main codebase in the meantime - as it seems an "obvious" fix for a compiler warning which is being treated as an error - but I'd prefer the upstream fix to go in first |
richardlau
approved these changes
Jun 2, 2026
Member
Author
|
Merging - will queue up unofficial builds of v26.3.0 |
Member
Author
sxa
added a commit
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
More investigation is required to see if this can be properly enabled in some environments, and if not then it should be disabled in https://github.com/nodejs/node/blob/39b481b5c510d3a12b6eea15a17681e6773d0b5d/configure.py#L2343 but this is a tactical fix that should allow it to be released with functionality consistent with v26.1.0