readable-stream@3 #344
readable-stream@3 #344
Conversation
* add airtap for continuous browser tests * ad-hoc fixes for browser tests * comment out failing browser tests * restore safari * Updated. * more airtap quirks * remove --no-coverage for airtap * better sauce credentials for travis * Maybe better env variables for airtap * removed sauce credentials from .travis.yml * added back all browsers * added back loopback host * Updated README links for sauce and travis * Suport for IE11
|
I've just released [email protected]. Install it with |
| util.inspect.custom = 'custom'; | ||
| } | ||
|
|
||
| // TODO: add replacements instead |
There was a problem hiding this comment.
Should these be replaced before release?
| require('./browser/test-stream2-readable-from-list')(t); | ||
| require('./browser/test-stream2-transform')(t); | ||
| // require('./browser/test-stream2-readable-from-list')(t); | ||
| // require('./browser/test-stream2-transform')(t); |
| return 'The ' + name + ' method is not implemented'; | ||
| }); | ||
| createErrorType('ERR_STREAM_PREMATURE_CLOSE', 'premature close'); | ||
| createErrorType('ERR_STREAM_DESTROYED', 'the stream was destroyed'); |
There was a problem hiding this comment.
We used capital letters in Node.js for the beginning of the message.
In core ERR_STREAM_DESTROYED has the message: 'Cannot call %s after a stream was destroyed'
| createErrorType('ERR_UNKNOWN_ENCODING', function (arg) { | ||
| return 'Unknown encoding: ' + arg; | ||
| }, TypeError); | ||
| createErrorType('ERR_STREAM_UNSHIFT_AFTER_END_EVENT', 'stream.unshift() after end event'); |
There was a problem hiding this comment.
The error messages slightly diverge in general from core.
There was a problem hiding this comment.
Node.js test suite passes without changing anything regarding error codes. Would you be able to send a PR against this branch that updates the error messages to the one of Node.js core? All of those were ported by hand :/.
|
On node 8.11.1, readable-stream crashes the process with Do we really need that? Why would it not be included? |
|
working in my small test now |
There was a problem hiding this comment.
It's an enormous diff, but most of that seems to be from copying code from node core.
Given the amount of tests, and the fact that they all pass that seems to be the best measure of whether or not this works. The fact that this is a major release also somewhat lowers the stakes of accidentally breaking things in userland.
LGTM!
|
we probably want a changelog or a notice in the readme about what breaking changes are in v3 to make upgrading easier, otherwise LGTM |
|
@calvinmetcalf done. |
As titled, this is a port of Node.js 10.5.0.
It includes all the semver-major changes of both Node 9 and 10.
Fixes #283
Fixes #284
Fixes #212
Fixes #297
Fixes #346
Fixes #339
Fixed #335