-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destroy/pump #283
Comments
I would say so, let's wait for nodejs/node#12925 to land. |
Relevant issues: |
I have a pull I've started a bit back that I can clean up with a bit and submit it, I was waiting on destroy to land first |
@calvinmetcalf I think you can fire that, and we can discuss it in the issue tracker. |
yeah I need to clean it up, I had been waiting on destroy to land
…On Tue, Jun 6, 2017 at 9:58 AM Matteo Collina ***@***.***> wrote:
@calvinmetcalf <https://github.com/calvinmetcalf> I think you can fire
that, and we can discuss it in the issue tracker.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABE4n1-uE1K8qRsvleCxb2ITQBA_umypks5sBVr6gaJpZM4NT_qE>
.
|
Any news here? Or is it blocked on landing in node core? Would love to be able to just depend on readable stream 🙂 |
@SimenB it's just work that needs doing. Do you want to help a bit? |
My understanding of stream internals are next to none, so I'm unfortunately not much help with that 🙁 |
nodejs/node#12925 landed in Version 8.0.0, 2017-05-30 |
since pump relies on destroy, we probably want destroy in before we do pump.
The text was updated successfully, but these errors were encountered: