Skip to content

feat: created theme provider and remove next.app.mjs #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 5 commits into from
Jul 4, 2023
Merged

feat: created theme provider and remove next.app.mjs #5469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86566c3
feat: created theme provider
ovflowd Jul 3, 2023
2284e2f
chore: deleted next.app.mjs and have dedicated app trees
ovflowd Jul 3, 2023
177a737
chore: theme provider handle the font family
ovflowd Jul 3, 2023
e1a18ad
chore: separate import from type imports
ovflowd Jul 3, 2023
17db6fa
chore: remove unnecessary dependencies
ovflowd Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions .storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
import type { StorybookConfig } from '@storybook/nextjs';

const config: StorybookConfig = {
stories: ['../components/**/*.stories.@(ts|tsx)'],
stories: ['../components/**/*.stories.tsx'],
addons: ['@storybook/addon-controls', '@storybook/addon-interactions'],
framework: {
name: '@storybook/nextjs',
options: {},
},
features: {
storyStoreV7: true,
},
docs: {
autodocs: 'tag',
},
framework: { name: '@storybook/nextjs', options: {} },
features: { storyStoreV7: true },
docs: { autodocs: 'tag' },
staticDirs: ['../public'],
core: { disableTelemetry: true },
};

export default config;
22 changes: 13 additions & 9 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import type { Preview } from '@storybook/react';
import NextImage from 'next/image';
import { SiteProvider } from '../providers/siteProvider';
import { ThemeProvider } from '../providers/themeProvider';
import { LocaleProvider } from '../providers/localeProvider';
import { openSans } from '../util/nextFonts';
import BaseApp, { setAppFonts } from '../next.app';
import type { Preview } from '@storybook/react';

import '../styles/index.scss';

Expand All @@ -23,15 +25,17 @@ const preview: Preview = {
},
};

setAppFonts([openSans.style.fontFamily]);

export const decorators = [
Story => (
<BaseApp>
<div data-test-id="story-root">
<Story />
</div>
</BaseApp>
<SiteProvider>
<LocaleProvider>
<ThemeProvider font={openSans.style.fontFamily}>
<div data-test-id="story-root">
<Story />
</div>
</ThemeProvider>
</LocaleProvider>
</SiteProvider>
),
];

Expand Down
48 changes: 0 additions & 48 deletions next.app.tsx
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ const nextConfig = {
// We disable the support for legacy browsers which should reduce the polyiffing
// and the overall bundle size for the Node.js Website client runtime
legacyBrowsers: false,
// We want all Next.js scripts to be registered as Service Workers, which
// reduces the JavaScript load time on cache hits (this uses Workbox)
// @see https://developer.chrome.com/docs/workbox/
nextScriptWorkers: true,
// This feature reduces the Next.js memory consumption by compartimentalising
// the Webpack builds into smaller threads that are responsible for building
// smaller pieces of the website instead of all pages at onces
Expand Down
Loading