-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: created theme provider and remove next.app.mjs #5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ovflowd
merged 5 commits into
nodejs:main
from
ovflowd:chore/theme-provider-and-separate-base-apps
Jul 4, 2023
Merged
feat: created theme provider and remove next.app.mjs #5469
ovflowd
merged 5 commits into
nodejs:main
from
ovflowd:chore/theme-provider-and-separate-base-apps
Jul 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AugustinMauroy
approved these changes
Jul 3, 2023
Member
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
araujogui
approved these changes
Jul 3, 2023
shanpriyan
approved these changes
Jul 3, 2023
Contributor
shanpriyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
Issues/PRs related to the Repository Infra
website redesign
Issue/PR part of the Node.js Website Redesign
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
themeProviderfor theMUITheme Provider,next-themesTheme Provider, andframer-motionMotion Config.It also applies the Font Family for the MUI Theme and
global jsxstyle.This PR then removes the shared
next.app.mjsand has a dedicated app tree for the legacy Websitepages/_app.tsxand the new website layouts that are on Storybook.storybook/preview.tsxIn the future we can recreate the shared
next.app.mjsonce that both_app.tsxandpreview.tsxshare the same base app tree.Related Issues
Relates to #5460