Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 3, 2023

Description

This PR introduces the themeProvider for the MUI Theme Provider, next-themes Theme Provider, and framer-motion Motion Config.

It also applies the Font Family for the MUI Theme and global jsx style.

This PR then removes the shared next.app.mjs and has a dedicated app tree for the legacy Website pages/_app.tsx and the new website layouts that are on Storybook .storybook/preview.tsx

In the future we can recreate the shared next.app.mjs once that both _app.tsx and preview.tsx share the same base app tree.

Related Issues

Relates to #5460

@ovflowd ovflowd requested a review from a team as a code owner July 3, 2023 10:45
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:51am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:51am

@ovflowd ovflowd added website redesign Issue/PR part of the Node.js Website Redesign infrastructure Issues/PRs related to the Repository Infra labels Jul 3, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 3, 2023 10:46 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 3, 2023 10:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 3, 2023 10:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 3, 2023 10:56 Inactive
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 3, 2023 11:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 3, 2023 11:38 Inactive
Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 4, 2023 08:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 4, 2023 08:51 Inactive
@ovflowd ovflowd merged commit 05152df into nodejs:main Jul 4, 2023
@ovflowd ovflowd deleted the chore/theme-provider-and-separate-base-apps branch July 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues/PRs related to the Repository Infra website redesign Issue/PR part of the Node.js Website Redesign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants