-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blm: convert to banner #3246
blm: convert to banner #3246
Conversation
Yes and yes, imo |
Yes and yes, imo |
+1 to landing anytime from now, including fast-tracking - aligning with the duration we discussed and decided, for the current banner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Please leave this message to US region only. We're not all Americans. People around the globe use Node and many of us are not involved in US politics and social problems. |
@Jakub-Piskorz the current implementation will have the banner on every version of the website. |
We originally discussed keeping the BLM landing page up for a week. This is a suggested implementation for what we can replace it with. It makes a new landing page /en/black-lives-matter/ that preserves the entire original BLM landing site and adds a link to it using our Security Release notification banner.
If there are no objections I'm going to land this in 2 hours |
The commit improves the visual appeal of the BLM CTA. Notes: https://user-images.githubusercontent.com/17770407/87524387-1cbf2f00-c656-11ea-8e94-7f80de3ed847.png https://user-images.githubusercontent.com/17770407/87524580-53954500-c656-11ea-8991-2935a8fcfdef.png Refs: #3246 Post-Feedback: https://user-images.githubusercontent.com/17770407/92166219-3f73f580-ee06-11ea-893c-0017d5d00ad0.png
Would it be OK to also include a statement in support of free and fair elections? This is after all a human right (see article 21 of the Human Rights declaration). I am from a country devastated because of the lack of free and fair elections (Venezuela) and would love to extend this message of hope for the forgotten victims of the lack of this human right. |
We originally discussed keeping the BLM landing page up for a week.
This is a suggested implementation for what we can replace it with.
It makes a new landing page /en/black-lives-matter/ that preserves
the entire original BLM landing site and adds a link to it using our
Security Release notification banner.
Two outstanding question.