Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blm: convert to banner #3246

Merged
merged 1 commit into from
Jun 15, 2020
Merged

blm: convert to banner #3246

merged 1 commit into from
Jun 15, 2020

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Jun 12, 2020

We originally discussed keeping the BLM landing page up for a week.
This is a suggested implementation for what we can replace it with.
It makes a new landing page /en/black-lives-matter/ that preserves
the entire original BLM landing site and adds a link to it using our
Security Release notification banner.

Two outstanding question.

  1. Should we change the style of the banner to have a black background?
  2. Should we wait until Monday to change it?

localhost_8080_en_ (4)

@addaleax
Copy link
Member

  1. Should we change the style of the banner to have a black background?

  2. Should we wait until Monday to change it?

Yes and yes, imo

@WaleedAshraf
Copy link
Contributor

Yes and yes, imo

@MylesBorins
Copy link
Contributor Author

Updated colors. Before and after hover below

localhost_8080_en_ (5)

localhost_8080_en_ (6)

@gireeshpunathil
Copy link
Member

+1 to landing anytime from now, including fast-tracking - aligning with the duration we discussed and decided, for the current banner.

@MylesBorins
Copy link
Contributor Author

updated. The BLM banner is now a unique element and stylesheet. Took some liberties with the design

blm-banner

@MylesBorins MylesBorins marked this pull request as draft June 12, 2020 06:16
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@MylesBorins MylesBorins marked this pull request as ready for review June 14, 2020 01:29
@Jakub-Piskorz
Copy link

Please leave this message to US region only. We're not all Americans. People around the globe use Node and many of us are not involved in US politics and social problems.

@MylesBorins
Copy link
Contributor Author

@Jakub-Piskorz the current implementation will have the banner on every version of the website.

We originally discussed keeping the BLM landing page up for a week.
This is a suggested implementation for what we can replace it with.
It makes a new landing page /en/black-lives-matter/ that preserves
the entire original BLM landing site and adds a link to it using our
Security Release notification banner.
@yosuke-furukawa yosuke-furukawa requested review from nschonni and yosuke-furukawa and removed request for nschonni June 15, 2020 10:40
@MylesBorins
Copy link
Contributor Author

If there are no objections I'm going to land this in 2 hours

@bnb
Copy link
Contributor

bnb commented Jun 15, 2020

:shipit:

@gdelfino
Copy link

gdelfino commented Feb 9, 2021

Would it be OK to also include a statement in support of free and fair elections? This is after all a human right (see article 21 of the Human Rights declaration). I am from a country devastated because of the lack of free and fair elections (Venezuela) and would love to extend this message of hope for the forgotten victims of the lack of this human right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.