Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues with BLM landing page #3257

Closed
MylesBorins opened this issue Jun 16, 2020 · 8 comments · Fixed by #3265
Closed

Accessibility issues with BLM landing page #3257

MylesBorins opened this issue Jun 16, 2020 · 8 comments · Fixed by #3265

Comments

@MylesBorins
Copy link
Contributor

Hey All,

We received an email report that the links on the BLM landing page were hard to read for those who can't distinguish color contrast well.

Did a quick report and saw that there are indeed some accessibility improvements we can make on the page

https://try.powermapper.com/demo/Report/577ee505-f5f6-425e-b1ca-450447bd7cce

I've not run this across the entire site, but as the BLM landing page borrows a bunch of the broader styles it might be a site wide issue. i'll try and find some time to fix this, but if anyone wants to take a pass at it first please don't wait for me.

@davidfekke

This comment has been minimized.

@nschonni
Copy link
Member

nschonni commented Jun 16, 2020

@davidfekke that already happened in #3246

@MylesBorins Looking at Wave, I'm not seeing any contrast issues flagged https://wave.webaim.org/report#/https://nodejs.org/en/black-lives-matter/ but that can sometimes be subjective, even if the ratio is correct

@MylesBorins
Copy link
Contributor Author

@davidfekke the change to make a banner landed yesterday. The original plan was to replace the landing page for a week.

@Trott
Copy link
Member

Trott commented Jun 17, 2020

@MylesBorins Looking at Wave, I'm not seeing any contrast issues flagged https://wave.webaim.org/report#/https://nodejs.org/en/black-lives-matter/ but that can sometimes be subjective, even if the ratio is correct

https://wave.webaim.org/report#/https://nodejs.org/en/black-lives-matter/ flags 32 color contrast issues for me, all in links.

Screen Shot 2020-06-16 at 9 20 58 PM

@nschonni
Copy link
Member

nschonni commented Jun 17, 2020

Weird, maybe a browser related thing? I'm running in Firefox on Windows 10
image

@Trott
Copy link
Member

Trott commented Jun 17, 2020

Weird, maybe a browser related thing? I'm running in Firefox

I was running in Chrome but I get the same 32 errors in Firefox too. I'm on macOS.

@nschonni
Copy link
Member

OK, think I figured out why I wasn't seeing it. I use Stylish for custom CSS, and even though I toggled it off, it seems like it was still picked up in the iframe

@XhmikosR
Copy link
Contributor

XhmikosR commented Jun 18, 2020

The main page passes WCAG2AA AFAICT. I remember I checked it in the past also.

EDIT: NVM, this issue is for https://nodejs.org/en/black-lives-matter/ which indeed has issues.

@MylesBorins MylesBorins changed the title Accessibility issues with BLM landing page (and maybe entire site?) Accessibility issues with BLM landing page Jun 19, 2020
MylesBorins added a commit that referenced this issue Jun 19, 2020
MylesBorins added a commit that referenced this issue Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants