v7.2.0 proposal #9745

Fishrock123 · 2016-11-22T18:09:47Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Description of change

Planned for later today. (Shortly)

Notable changes (unformatted)

[c4f33b48f7] - (SEMVER-MINOR) src: extend HeapStatistics with new fields (Gareth Ellis) #8610
[163397a206] - (SEMVER-MINOR) process: add process.memoryUsage.external (Fedor Indutny) #9587
[0a3e5cc57a] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve6() (Ben Noordhuis) #9296
[1bd79368cd] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve4() (Ben Noordhuis) #9296
[08a7e7b009] - (SEMVER-MINOR) crypto: return this in setAuthTag/setAAD (Kirill Fomichev) #9398
[786631c7b4] - deps: upgrade libuv to 1.10.1 (cjihrig) #9647
[1520afd336] - deps: update V8 to 5.4.500.43 (Michaël Zasso) #9697

CI: https://ci.nodejs.org/job/node-test-pull-request/4945/

google build tool gclient doesn't support svn anymore. Updating v8 build script to use git instead. PR-URL: #9393 Reviewed By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9412 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>

We now have multiple tap producers; just ignore all files with the `.tap` extension. PR-URL: #9262 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>

This makes yaml-ish parsers happy. Note: gtest still seems to output the expected/result slightly different making the full traceback less informational. PR-URL: #9262 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Produce a tap13-compatible output which makes it simpler to parse. Output is still readable by the jenkins tap plugin. PR-URL: #9262 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Looks like the link to cli.md is missing in vm.md: https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code Added the link which can be verified by using the following commands: $ make doc $ open out/doc/api/vm.html PR-URL: #9481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Writing data to TLSWrap instance during handshake will result in it being queued in `write_item_queue_`. This queue won't get cleared up until the end of the handshake. Technically, it gets cleared on `~TLSWrap` invocation, however this won't ever happen because every `WriteWrap` holds a reference to the `TLSWrap` through JS object, meaning that they are doomed to be alive for eternity. To breach this dreadful contract a knight shall embark from the `close` function to kill the dragon of memory leak with his magic spear of `destroySSL`. `destroySSL` cleans up `write_item_queue_` and frees `SSL` structure, both are good for memory usage. PR-URL: #9586 Reviewed-By: Ben Noordhuis <[email protected]>

Add --coverage option to configure to support compiling for generation of C based coverage reports PR-URL: #9463 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

test-debug-signal-cluster contains a watchdog timer that results in false positives in CI. Remove the watchdog timer and let the test runner determine that the test has timed out. PR-URL: #9476 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #9389 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Remove unnecessary named function. V8 will do a better job inferring the name from the assignment to a property. The current formulation does not pass linting. PR-URL: #9524 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #7894 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

The `/` character does not need to be escaped when occurring inside a character class in a regular expression. Remove such instances of escaping in the code base. PR-URL: #9485 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>

`test-regress-GH-897` is dependent on a timer firing within a period of time. Especially on some of the FreeBSD hosts on CI, we have seen tests like that fail when run in parallel. (This may have nothing to do with FreeBSD and may just mean that the hosts are resource-constrained.) Move this test to sequential as we have done with several other timer-dependent tests recently. The test has also been refactored and documented via comments. PR-URL: #9487 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

The depth benchmark for timers sets a timer that sets a timer that sets a timer that... 500K of them. Since each timer has to wait for the next tick of the event loop this benchmark takes a very long time to run compared to the breadth test that is already in the file. This may be more of an event loop benchmark than a timer benchmark. Reduce the number of iterations for the depth test as it's really just running the iterations in sequence, not in parallel. And even on an infinitely fast machine, it would take over 8 minutes to run because each tick of the event loop would have to wait 1ms before firing the timer. Split the depth and breadth benchmarks so that their `N` values can be set independently. Do some minor refactoring to the benchmarks (but no ES6 additions so that the benchmarks can still be run with old versions of Node.js). Refs: #9493 PR-URL: #9497 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

Move copy/pasted callback into its own function. PR-URL: #9498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: #9499 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

The tick-processor tests are inherently non-deterministic. They therefore have false negatives from time to time. They also sometimes leave extra processes running. Move them to their own directory until these issues are sorted. Note that this means that the tests will not be run in CI. Like the inspector tests and other tests, they will have to be run manually when they are wanted. PR-URL: #9506 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matthew Loring <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #9453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9527 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: #9502 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #9495 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1 PR-URL: #9508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

PR-URL: #9514 Reviewed-By: Roman Reiss <[email protected]>

PR-URL: #9505 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Refs: nodejs/CTC#16 PR-URL: #9545 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

* buffer-to-string comparison replaced with string-to-string comparison * equal -> strictEqual * var -> const * rename identifiers to avoid masking PR-URL: #9536 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add an option to retrieve the Time-To-Live of the AAAA record. PR-URL: #9296 Refs: #5893 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

PR-URL: #9704 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Previously not all codepaths set `timer._idleTimeout = -1` for canceled or closed timers, and not all codepaths checked it either. Unenroll uses this to say that a timer is indeed closed and it is the closest thing there is to an authoritative source for this. Refs: #9606 Fixes: #9561 PR-URL: #9685 Reviewed-By: Rich Trott <[email protected]>

addaleax · 2016-11-22T19:12:20Z

doc/changelogs/CHANGELOG_V7.md

+* [[`9491352b86`](https://github.com/nodejs/node/commit/9491352b86)] - **test**: remove watchdog in test-debug-signal-cluster (Rich Trott) [#9476](https://github.com/nodejs/node/pull/9476)
+* [[`6a94ffb1cf`](https://github.com/nodejs/node/commit/6a94ffb1cf)] - **test**: output tap13 instead of almost-tap (Johan Bergström) [#9262](https://github.com/nodejs/node/pull/9262)
+* [[`02c2bf7d34`](https://github.com/nodejs/node/commit/02c2bf7d34)] - **timers**: use consistent checks for canceled timers (Jeremiah Senkpiel) [#9685](https://github.com/nodejs/node/pull/9685)
+* [[`ee65b4872d`](https://github.com/nodejs/node/commit/ee65b4872d)] - **tls**: fix leak of WriteWrap+TLSWrap combination (Fedor Indutny) [#9586](https://github.com/nodejs/node/pull/9586)


Judging from the conversation on #9626 (v4.x backport of the same commit) this one is probably “notable changes”-worthy

Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

Fishrock123 · 2016-11-22T20:37:18Z

Idk why the CI didn't post to the PR but it was green. i added two more commits though so...

CI: https://ci.nodejs.org/job/node-test-pull-request/4950/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/454/

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) #9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

Fishrock123 · 2016-11-22T22:15:40Z

Building at https://ci-release.nodejs.org/job/iojs+release/1360/

Fishrock123 · 2016-11-22T22:32:12Z

Rebuilding due to OS X issues: https://ci-release.nodejs.org/job/iojs+release/1361/

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) #9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

Refs: nodejs/node#9745

Fishrock123 · 2016-11-22T23:55:21Z

Live at https://nodejs.org/en/blog/release/v7.2.0/

Some of the other release bits will be done tomorrow... I'm coming down with a cold and feel pretty garbage.

PR-URL: #9745

Fishrock123 · 2016-12-03T20:16:14Z

@thealphanerd Thanks for catching the staging commit, was sick at the time and didn't get around to it 😓

Jaideep Bajwa and others added 30 commits November 11, 2016 10:48

gitignore: ignore all tap files

6b01bfa

We now have multiple tap producers; just ignore all files with the `.tap` extension. PR-URL: #9262 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>

zlib: name every function Ref: #8913

841a2c4

PR-URL: #9389 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

zlib: fix linting recently-introduced lint error

adcc5b1

Remove unnecessary named function. V8 will do a better job inferring the name from the assignment to a property. The current formulation does not pass linting. PR-URL: #9524 Reviewed-By: Anna Henningsen <[email protected]>

doc: add npm link to README

6f513e0

PR-URL: #7894 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

test: refactor make-callback-recurse test

dab3e45

Move copy/pasted callback into its own function. PR-URL: #9498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

doc: Fix inaccuracy in https.request docs

c07f648

PR-URL: #9453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

doc: fix link to Event Loop page

62478eb

PR-URL: #9527 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

doc: grammar and structure revisions of wg doc

a412b9f

PR-URL: #9495 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

doc: added types to path docs

7488b00

PR-URL: #9514 Reviewed-By: Roman Reiss <[email protected]>

doc: fix the index order in pseudocode of modules

7c9e8cb

fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

bnoordhuis and others added 3 commits November 22, 2016 11:15

dns: implement {ttl: true} for dns.resolve6()

0a3e5cc

Add an option to retrieve the Time-To-Live of the AAAA record. PR-URL: #9296 Refs: #5893 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

doc: fix typo in assert code example

fa98eec

PR-URL: #9704 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Fishrock123 added meta Issues and PRs related to the general management of the project. v7.x labels Nov 22, 2016

addaleax reviewed Nov 22, 2016

View reviewed changes

Fishrock123 force-pushed the v7.2.0-proposal branch from 4d825a9 to 70404e7 Compare November 22, 2016 20:35

phillipj mentioned this pull request Nov 22, 2016

Jenkins build status not visible in big PRs nodejs/github-bot#97

Closed

Fishrock123 force-pushed the v7.2.0-proposal branch from 70404e7 to c1aa949 Compare November 22, 2016 22:13

Fishrock123 merged commit c1aa949 into v7.x Nov 22, 2016

Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Nov 22, 2016

Blog: v7.2.0 release post

1b627a4

Refs: nodejs/node#9745

lpinca deleted the v7.2.0-proposal branch November 23, 2016 07:40

lpinca restored the v7.2.0-proposal branch November 23, 2016 07:41

MylesBorins pushed a commit that referenced this pull request Nov 24, 2016

Working on v7.2.1

8cabe28

PR-URL: #9745

MylesBorins deleted the v7.2.0-proposal branch December 15, 2016 18:45

phillipj mentioned this pull request Oct 31, 2017

jenkins: paginate PR commits to find the latest commit nodejs/github-bot#153

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v7.2.0 proposal #9745

v7.2.0 proposal #9745

Fishrock123 commented Nov 22, 2016 •

edited

Loading

addaleax Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Dec 3, 2016

v7.2.0 proposal #9745

v7.2.0 proposal #9745

Conversation

Fishrock123 commented Nov 22, 2016 • edited Loading

Checklist

Description of change

Notable changes (unformatted)

addaleax Nov 22, 2016

Choose a reason for hiding this comment

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Nov 22, 2016

Fishrock123 commented Dec 3, 2016

Fishrock123 commented Nov 22, 2016 •

edited

Loading