Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: name every function #9389

Closed
wants to merge 2 commits into from
Closed

zlib: name every function #9389

wants to merge 2 commits into from

Conversation

solebox
Copy link
Contributor

@solebox solebox commented Oct 31, 2016

Checklist
  • [ v] make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • [ v] commit message follows commit guidelines
Affected core subsystem(s)

zlib

Description of change

named handlers

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Oct 31, 2016
@@ -347,7 +347,7 @@ function Zlib(opts, mode) {

var self = this;
this._hadError = false;
this._handle.onerror = function(message, errno) {
this._handle.onerror = (message, errno) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change this one to an arrow function. There's really no point in doing so here. I would just add a name to the existing function

@solebox
Copy link
Contributor Author

solebox commented Nov 3, 2016

no CI?

@silverwind
Copy link
Contributor

Here you go: https://ci.nodejs.org/job/node-test-pull-request/4774/

@solebox
Copy link
Contributor Author

solebox commented Nov 8, 2016

@silverwind boink?

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2016

Failure on arm in CI looks un-related so should be good to land

@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2016

Landed as 77ec310

@mhdawson mhdawson closed this Nov 8, 2016
mhdawson pushed a commit that referenced this pull request Nov 8, 2016
PR-URL: #9389
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 9, 2016

This has broken linting on CI because it violates a lint rule that landed since CI was run for it 5 days ago. :-(

@Trott
Copy link
Member

Trott commented Nov 9, 2016

The fix is at #9524.

@solebox solebox deleted the zlib branch November 19, 2016 15:37
addaleax pushed a commit that referenced this pull request Nov 22, 2016
PR-URL: #9389
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants