Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-tls-getcipher #853

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

As discussed in #826.

cc: @bnoordhuis

@mscdex
Copy link
Contributor

mscdex commented Feb 15, 2015

Shouldn't the commit line have a "test:" prefix instead of "tls:"?

@silverwind
Copy link
Contributor Author

I was unsure about that, you're probably right.

The test blindly assumes that the default cipher suite supports RC4
ciphers. This corrects the case where RC4 might not be available in the
default ciphers by setting the client to use the same suite as the
server.
@silverwind silverwind changed the title tls: fix test-tls-getcipher test: fix test-tls-getcipher Feb 15, 2015
bnoordhuis pushed a commit that referenced this pull request Feb 15, 2015
The test blindly assumes that the default cipher suite supports RC4
ciphers. This corrects the case where RC4 might not be available in the
default ciphers by setting the client to use the same suite as the
server.

PR-URL: #853
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Thanks Roman, landed in 30e340a. I wouldn't have minded if you had made it part of the original pull request but this way is fine too.

@bnoordhuis bnoordhuis closed this Feb 15, 2015
@rvagg rvagg mentioned this pull request Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants