Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release proposal: v1.3.0 #872

Closed
rvagg opened this issue Feb 18, 2015 · 25 comments
Closed

Release proposal: v1.3.0 #872

rvagg opened this issue Feb 18, 2015 · 25 comments
Labels
meta Issues and PRs related to the general management of the project.
Milestone
1.3.0

Comments

@rvagg
Copy link
Member

rvagg commented Feb 18, 2015

I wrote a tool, changelog-maker to generate this changelog. It uses the metadata to cross-reference the PR-URL, include that in the summary and also note anything that's labelled with semver* labels so they stand out (see the entry for 77f35861d0 above).

The only concern I have with this is that it makes the plain-text version of the CHANGELOG.md file very unweildy and difficult to read.. e.g. one line will look like this:

* [[`fb28c91074`](https://github.com/iojs/io.js/commit/fb28c91074)] -
**src**: fix add-on builds, partially revert 8aed9d66 (Ben Noordhuis)
[#868](https://github.com/iojs/io.js/pull/868)

So .. before I go putting this in CHANGELOG.md, please comment if you think this is going to be a problem. My preference is for this to be a useful Markdown doc, but perhaps it will bother others enough to object!

Re 1.3.0: I think we'll give this ~2 days before it's released if there are no objections.
@YurySolovyov
Copy link

isn't it better so sort those commits by category ?

@rvagg
Copy link
Member Author

rvagg commented Feb 18, 2015

@YuriSolovyov yeah, that'd be nice, but I suspect that the ordering matters more than being able to view them as a group. I'll do a "Notable changes" that has things grouped.

Also, the above list is in reverse order, I've decided that this probably isn't a good idea so I'll switch it before publishing.

@YurySolovyov
Copy link

well, that was a "minimal" proposal, that just require tweaking your script/tool
I think creating "Notable changes" requires more work since you have to always pick changes that seem "notable", and this is more work to do.
thanks for looking at it anyway.

@aheckmann
Copy link
Contributor

RE: ordering vs categorizing. What I found worked well for me in the past
is a combination of both. Categorize them but within each category, order
by commit date.

On Wed, Feb 18, 2015 at 2:57 AM, Yuri [email protected] wrote:

well, that was a "minimal" proposal, that just require tweaking your
script/tool
I think creating "Notable changes" requires more work since you have to
always pick changes that seem "notable", and this is more work to do.
thanks for looking at it anyway.

—
Reply to this email directly or view it on GitHub
#872 (comment).

Aaron
@aaronheckmann https://twitter.com/#!/aaronheckmann
soundcloud.com/ajhecky
github.com/aheckmann

@silverwind
Copy link
Contributor

Regarding #826: Please mention in the release notes that TLS (and in turn HTTPS) now rely on a stronger default cipher suite which excludes the RC4 cipher. If users still want to use RC4, they have to specify their own ciphers.

Also, I'd appreciate if someone could review #845 before this release. This should be in the docs for this release. Edit: It's merged!

@popomore popomore mentioned this issue Feb 18, 2015
Closed
@Fishrock123 Fishrock123 added this to the 1.3.0 milestone Feb 18, 2015
@rvagg
Copy link
Member Author

rvagg commented Feb 18, 2015

https://iojs.org/download/nightly/v1.2.1-nightly20150218fb28c91074/ RC1 fwiw, will do another RC today and release tomorrow

@unbornchikken
Copy link

I'd appreciate if someone could take a look at this issue #877 before this release, because by my opinion this is a serious bug originating from 0.11.15, that makes debugging io.js applications a huge PITA.

@Ndrou
Copy link

Ndrou commented Feb 19, 2015

@unbornchikken 👍

@mikeal
Copy link
Contributor

mikeal commented Feb 19, 2015

@unbornchikken I'll make sure we talk about it today in the Tracing WG meeting but we don't hold up releases for stuff like this. But, we're releasing every week so once it is fixed it'll land in a new release quite soon :)

@unbornchikken
Copy link

Gonna take me a while to get used to that I don't have to wait for two years for a new release. :) Thanks.

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

OK, no criticism of the heavy Markdown, and on thinking it through further -- if you want a cleaner list then just git log for yourself, a CHANGELOG should be more helpful! So in lieu of further feedback I'm pushing ahead with experimentation.

As per @aheckmann's suggestion, I'm trying commit grouping here and it's actually quite nice:

I might hold up release pending resolution of #894 for a few more hours (partly because I'm kind of busy right at this moment anyway!). If it's not resolved within the next 8 or so hours then I'll get the release out and just note that in the Known Issues section and push for a patch release ASAP.

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

FYI this is with changelog-maker --group, there is also a --simple that strips out all of the Markdown cruft for easier terminal viewing.

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

CHANGELOG.md header so far, unfortunately I can't find any other notable changes to mention here, does anybody else want to highlight things?

2015-02-20, Version 1.3.0, @rvagg

Notable changes

  • url:
    • url.resolve('/path/to/file', '.') now returns /path/to/ with the trailing slash, url.resolve('/', '.') returns /. #278 (Amir Saboury)
  • tls:
    • tls (and in turn https) now rely on a stronger default cipher suite which excludes the RC4 cipher. If you still want to use RC4, you have to specify your own ciphers suite. #826 (Roman Reiss)
  • assert:

Known issues

  • Surrogate pair in REPL can freeze terminal #690
  • Not possible to build io.js as a static library #686
  • process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774 still pending resolution.

Commits

...

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

https://iojs.org/download/nightly/v1.2.1-nightly201502201bf91878e7/ RC2 I suppose, should be pretty close to what 1.3.0 ends up being

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/184/ full CI run

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

Going to do the release dance now.

Under "Known issues", putting:

@silverwind
Copy link
Contributor

Let me rephrase that tls entry in the notes:

  • The default cipher suite used by tls and https has been changed to one that achieves Perfect Forward Secrecy with all modern browsers. Additionally, insecure RC4 ciphers have been excluded. If you absolutely require RC4, please specify your own cipher suites.

@silverwind
Copy link
Contributor

Calling dns.setServers() while a DNS query is in process can cause process crash on a failed assertion

Missing a 'the' before 'process', and 'to' after it :)

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

urgh, too late, I should have said "progress" actually

@silverwind
Copy link
Contributor

Well, it's not that bad, I just wanted to expand on the reason for the tls change, but yours gets the RC4 message through too.

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

tagged v1.3.0 @ 1d7a47f

Release builds in progress here: https://jenkins-iojs.nodesource.com/job/iojs+release/24/

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

done, https://iojs.org/dist/latest/

@iojs/website ping 1.3.0 bump pls

@rvagg rvagg closed this as completed Feb 20, 2015
@brendanashworth
Copy link
Contributor

Having issues, on HEAD (26ebe98), I'm getting conflicting versions:

> process.version
'v1.3.1'

$ iojs --version
v1.2.1

@mikeal
Copy link
Contributor

mikeal commented Feb 21, 2015

hrm, can't reproduce

% nvm install iojs-v1.3.0                                                                                                                                                                      ~
######################################################################## 100.0%
WARNING: checksums are currently disabled for io.js
Now using node iojs-v1.3.0
% node --version                                                                                                                                                                               ~
v1.3.0
% node                                                                                                                                                                                         ~
> process.version
'v1.3.0'

@brendanashworth
Copy link
Contributor

@mikeal oop, it was an issue with me building from source and my computer's symlinks. My fault, thanks!

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
@leonardoadame leonardoadame mentioned this issue Nov 28, 2023
Open
@aliscco aliscco mentioned this issue Nov 28, 2023
Open
@leonardoadame leonardoadame mentioned this issue Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
Open
Open
This was referenced Nov 30, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
10 participants
@mikeal @mscdex @silverwind @aheckmann @rvagg @Fishrock123 @YurySolovyov @brendanashworth @unbornchikken @Ndrou