Update v8_inspector

[ofrobots]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

deps, inspector

Description of change

Update to the latest version of upstream v8_inspector.

/cc @eugeneo, @bnoordhuis

[bnoordhuis]

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.

[eugeneo]

I added snprintf macro, same as the one in Node sources. Is it possible to
test this on SmartOS - https://github.com/eugeneo/node/tree/snprintf?

The macro is in PlatformSTL.h

On Thu, Aug 18, 2016 at 12:27 AM Ben Noordhuis [email protected]
wrote:

Doesn't seem to build on smartos because the toolchain is so ancient there:

InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
std::snprintf(buffer, length, "%.3g", number);

The Windows CI failure appears to have been a network outage.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrfBfaVrZkD2W3m0I7_i1bY0IHBadks5qhAlsgaJpZM4Jm-sE
.

[bnoordhuis]

https://ci.nodejs.org/job/node-test-commit-smartos/3813/

[eugeneo]

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis [email protected]
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

[eugeneo]

How can I detect SmartOS? From a compiler message, my understanding is that
it has snprintf but not the std::snprintf.

On Fri, Aug 19, 2016 at 2:03 PM Eugene Ostroukhov [email protected]
wrote:

Thank you. Looks like the approach is correct in principle. I will put the
shim into std:: namespace.

On Fri, Aug 19, 2016 at 11:13 AM Ben Noordhuis [email protected]
wrote:

https://ci.nodejs.org/job/node-test-commit-smartos/3813/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8150 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARkrUvnWq6XkGplmCGZaUWYzWINkSi5ks5qhfIygaJpZM4Jm-sE
.

[bnoordhuis]

In libuv we wrap smartos-specific code in #ifdef _sun guards but that also covers other illumos derivatives and solaris proper. Perhaps @misterdjules has suggestions?

[eugeneo]

@bnoordhuis - Can you please test this branch? It imports existing snprintf into the std namespace. Looks like SmartOS has the snprintf in the global namespace.

[bnoordhuis]

https://ci.nodejs.org/job/node-test-commit-smartos/3861/

[misterdjules]

_sun is the right macro to test against when detecting the SmartOS platform.

[eugeneo]

I submitted the SmartOS fix to the Chrome yesterday and it is now available in the latest V8 inspector export.

[ofrobots]

Updated the PR to pick up upstream fixes from @eugeneo. New CI: https://ci.nodejs.org/job/node-test-pull-request/3801/

[ofrobots]

Launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/3813/ because of hiccups on the last one. AIX seems to be having issues in the CI in general today.

[ofrobots]

One more CI: https://ci.nodejs.org/job/node-test-pull-request/3846/. This PR does need an LGTM before I can land this (/cc @bnoordhuis)

[bnoordhuis]

LGTM

[ofrobots]

Landed as 1e0bfac...1b8accf.

[Bilge]

I have this problem.

/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::intToStr(int, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:23:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%d", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:28:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%f", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr3(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:33:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.3g", number);
     ^
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp: In function 'void blink::protocol::internal::doubleToStr6(double, char*, size_t)':
/root/buildroot-2016.11/output/build/nodejs-6.7.0/out/Release/obj/gen/blink/platform/inspector_protocol/InspectorProtocol.cpp:38:5: error: 'snprintf' is not a member of 'std'
     std::snprintf(buffer, length, "%.6g", number);
     ^

I am using a uClibc 0.9.33.2 toolchain (latest) available from this crosstool-NG project.

It is probably incorrect to change compilation strategy based on platform flags instead of detecting feature availability.

[eugeneo]

@Bilge I think you'll need to patch https://github.com/nodejs/node/blob/v6.7.0/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/PlatformSTL.h#L295