Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.6.0 pre-proposal #8428

Closed
Fishrock123 opened this issue Sep 6, 2016 · 7 comments
Closed

v6.6.0 pre-proposal #8428

Fishrock123 opened this issue Sep 6, 2016 · 7 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

I'd like to do this week's release. Here's a rough cut of the commits.

I need to fix up some conflicts to get everything ready and probably don;t have time to finish to make an actual PR today.

Aiming for tomorrow.


  • [10b3f131c2] - async_wrap: add a missing case to test-async-wrap-throw-no-init (yorkie) #8198
  • [2c9a86f01e] - buffer: directly use ArrayBuffer as the pool (Anna Henningsen) #8302
  • [2168432c36] - build: don't require processing docs for nightlies (Johan Bergström) #8325
  • [1657f12f75] - build: fix dependencies on AIX (Michael Dawson) #8285
  • [063d14e496] - build: fix dependencies on AIX (Michael Dawson) #8272
  • [18017d675b] - build: add missing files to zip and 7z packages (Richard Lau) #8069
  • [ed640ae4cb] - crypto: make malloc failure check cross-platform (Rich Trott) #8352
  • [a6f7b13d02] - crypto: fix getDecoder() encoding check (atstojanov) #8301
  • [0764bc4711] - _Revert_ "crypto: add crypto.timingSafeEqual" (James M Snell) #8225
  • [0fc5e0dcd9] - (SEMVER-MINOR) crypto: add crypto.timingSafeEqual (not-an-aardvark) #8040
  • [870faeef95] - deps: workaround clang-3.4 ICE (Ali Ijaz Sheikh) #8343
  • [61faabd938] - deps: v8_inspector update (Eugene Ostroukhov) #8150
  • [a945244830] - doc: add 2016-08-10 CTC meeting minutes (Josh Gavant) #8229
  • [e4ac083bad] - doc: update CI content in onboarding doc (Rich Trott) #8374
  • [dfe1c7e9b8] - doc: update authors list (James M Snell) #8346
  • [7e8d994e33] - doc: add return type of clientRequest.setTimeout (Mike Ralphson) #8356
  • [5930d59b0f] - doc: fix a wrong link,add '.md' to the link (Alexis374) #8315
  • [3905f48882] - doc: fix typos (Mike Ralphson) #8370
  • [8361c26cd5] - doc: fix broken link in dgram doc (Brian White) #8365
  • [ced2bc37c4] - doc: update targos email in readme per request (James M Snell) #8389
  • [2501a38b79] - doc: update landing pr info in onboarding doc (Rich Trott) #8344
  • [143d38c650] - doc: bad/better examples for fs.access() and fs.exists() (Dan Fabulich) #7832
  • [f7dd3bc19f] - doc: fix typo in stream doc (Hubert Mine) #8326
  • [56414b54d9] - doc: adding danbev to collaborators (Daniel Bevenius) #8359
  • [86067f0129] - doc: clarify that path on windows accepts / and \ (James M Snell) #8291
  • [1e0bfacc28] - doc: add lpinca to collaborators (Luigi Pinca) #8331
  • [488d37b3dc] - doc: doc that listen can be called multiple times (James M Snell) #8294
  • [61fa50d298] - doc: readline write() is processed as input (James M Snell) #8295
  • [f10e1ed455] - doc: 'ipc' is required with fork stdio option (James M Snell) #8290
  • [c8619ea3c3] - doc: improve fs.truncate functions' documentation (Sakthipriyan Vairamani) #7648
  • [df4880de55] - doc: add added: information for modules (Luigi Pinca) #8250
  • [a72a331536] - doc: fix onReadable reentry after unshift called (Zwb) #8200
  • [379d9162a2] - doc: add added: information for dgram (Luigi Pinca) #8196
  • [2367e6c901] - doc: add Myles Borins to the CTC (Rod Vagg) #8260
  • [7f1bb8044a] - doc: fix buf.readUIntBE, buf.readUIntLE examples (David Keeler) #8240
  • [e7866568e5] - doc: fix "timout" typo in timeout (Fangshi He) #8231
  • [6e50fc7637] - doc: include the optional options parameter (Sakthipriyan Vairamani) #7842
  • [932c824c60] - (SEMVER-MINOR) events: make memory leak warning more accessible (Anna Henningsen) #8298
  • [1050594c86] - http: fix connection upgrade checks (Brian White) #8238
  • [609a265aeb] - inspector: use script name for target title (Eugene Ostroukhov) #8243
  • [27fd2d7e61] - inspector: make sure all messages are dispatched (Eugene Ostroukhov) #8264
  • [b6db963915] - inspector: simplify buffer management (Eugene Ostroukhov) #8257
  • [1b8accfdd6] - inspector: use new inspector headers (Eugene Ostroukhov) #8150
  • [4863f6a121] - net: make holding the buffer in memory more robust (Anna Henningsen) #8252
  • [5bef38b627] - (SEMVER-MINOR) repl: Auto alignment for .editor mode (Prince J Wesley) #8241
  • [a00ccb0fb9] - src: normalize malloc, realloc (Michael Dawson) #7564
  • [a290ddfdc9] - src: unbreak build when compiling against uclibc (Ben Noordhuis) #8308
  • [a01e8bcf18] - src: moving f function call comment (Daniel Bevenius) #8405
  • [becbcc7981] - src: avoid duplicate AtExit functions (Ali Ijaz Sheikh) #8273
  • [1ffdee7c86] - test: mark pseudo-tty/no_dropped_stdio as flaky (Michael Dawson) #8385
  • [9826a79f54] - test: test non-buffer/string with zlib (Rich Trott) #8350
  • [2d2a2d7c78] - test: fix test-cluster-dgram-1 flakiness (Santiago Gimeno) #8383
  • [3504a98b72] - test: fix ::1 error in test-dns-ipv6 (Gibson Fahnestock) #8254
  • [a133b775e3] - test: fix fs-watch-recursive flakiness on OS X (Santiago Gimeno) #4629
  • [baa0ffdab3] - test: refactor/cleanup a number of cluster tests (James M Snell) #8261
  • [266270e618] - test: refactor parallel/test-process-env.js (Rich Trott) #8324
  • [f6e33ef8bc] - test: add test for zlib.create*Raw() (Rich Trott) #8306
  • [eca74a9d91] - test: cleanup test require symlink (Paul Grock) #8305
  • [e192825de0] - test: refactor test-debug-signal-cluster (Rich Trott) #8289
  • [4537cf2377] - test: additional refactoring/cleanup of buffer tests (James M Snell) #8283
  • [407069a29d] - test: add known issue test for path parse issue path (extname, parse) cannot handle extension correctly for directory #6229 (James M Snell) #8293
  • [82c7a9c40c] - test: make sure over truncation of file zero fills (Sakthipriyan Vairamani) #7648
  • [a6d53c6779] - test: add check in test-signal-handler (Rich Trott) #8248
  • [7053922c1a] - test: clean up / refactor buffer tests, remove duplication (James M Snell) #8256
  • [02ed21aa5c] - test: mark test-child-process-fork-dgram as flaky (Michael Dawson) #8274
  • [e3cb0bfec9] - test: refactor test-util-inspect (Rich Trott) #8189
  • [5a7a6d9b01] - tools: enable caching for jslint task (Rich Trott) #8296
  • [201115812e] - tools: update ESLint to 3.4.0 (Rich Trott) #8296
  • [51f96dfcfc] - url: keep auth in url.resolve() if host matches (Ilkka Myller) #8215
  • [1d0385f62d] - url: url.format() encodes all # in search (Ilkka Myller) #8072
  • [b3e7ac2605] - util: improve function signature of util._extend (Sakthipriyan Vairamani) #8187
  • [a60ed89178] - (SEMVER-MINOR) util: allow returning this from custom inspect (Anna Henningsen) #8174
  • [59714cb7b3] - (SEMVER-MINOR) util: allow symbol-based custom inspection methods (Anna Henningsen) #8174
@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Sep 6, 2016
@jasnell
Copy link
Member

jasnell commented Sep 7, 2016

[0764bc4] - Revert "crypto: add crypto.timingSafeEqual" (James M Snell) #8225
[0fc5e0d] - (SEMVER-MINOR) crypto: add crypto.timingSafeEqual (not-an-aardvark) #8040

These don't need to be pulled in. There's an effort to get timingSafeEqual back in that should land soon.

@Fishrock123
Copy link
Contributor Author

I keep running into this:

# embedded addons have been generated from the documentation.
for dirname in test/addons/*/; do \
        ./node deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
            --python="/usr/bin/python" \
            --directory="$PWD/$dirname" \
            --nodedir="$PWD" || exit 1 ; \
    done
buffer.js:520
Buffer.prototype[internalUtil.inspectSymbol] = function inspect() {
                 ^

ReferenceError: internalUtil is not defined
    at buffer.js:520:18
    at NativeModule.compile (bootstrap_node.js:497:7)
    at NativeModule.require (bootstrap_node.js:438:18)
    at util.js:4:33
    at NativeModule.compile (bootstrap_node.js:497:7)
    at Function.NativeModule.require (bootstrap_node.js:438:18)
    at setupGlobalVariables (bootstrap_node.js:204:31)
    at startup (bootstrap_node.js:41:5)
    at bootstrap_node.js:509:3
make[1]: *** [test/addons/.buildstamp] Error 1

cc @addaleax maybe?

@addaleax
Copy link
Member

addaleax commented Sep 7, 2016

Uh, yeah, that one’s on me I guess… I’ll do a backport PR for #8174, it should just be a one-line difference

@Fishrock123
Copy link
Contributor Author

now running into this:

crypto.js:103
  encoding = internalUtil.normalizeEncoding(encoding);
                          ^

TypeError: internalUtil.normalizeEncoding is not a function
    at getDecoder (crypto.js:103:27)
    at Cipheriv.Cipher.update (crypto.js:146:21)
    at Object.<anonymous> (/Users/Jeremiah/Documents/node/test/parallel/test-crypto-authenticated.js:332:23)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.runMain (module.js:590:10)
    at run (bootstrap_node.js:394:7)
Command: out/Release/node /Users/Jeremiah/Documents/node/test/parallel/test-crypto-authenticated.js

@Fishrock123
Copy link
Contributor Author

Looks like it is #8301 (comment)

@Fishrock123
Copy link
Contributor Author

Refs: #8437

@Fishrock123
Copy link
Contributor Author

Moving to #8457

Fishrock123 added a commit that referenced this issue Sep 9, 2016
Fishrock123 added a commit that referenced this issue Sep 9, 2016
Fishrock123 added a commit that referenced this issue Sep 14, 2016
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) #8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) #8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) #8174

Refs: #8428
Refs: #8457
PR-URL: #8466
Fishrock123 added a commit to Fishrock123/node that referenced this issue Sep 15, 2016
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
nodejs#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) nodejs#8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
nodejs#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
nodejs#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) nodejs#8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) nodejs#8174

Refs: nodejs#8428
Refs: nodejs#8457
PR-URL: nodejs#8466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

3 participants