zlib: set zlib.bytesRead end-of-life #55020
Open
+4
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
added
the
semver-major
nodejs-github-bot
added
needs-ci
anonrig
force-pushed
the
runtime-deprecate-zlib-bytes-read
branch
from
fc83cd8
to
34c1d02
Compare
benjamingr
approved these changes
Sep 19, 2024
|
You forgot to delete the relevant part from the test :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55020 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.02%
==========================================
Files 652 652
Lines 183764 183743 -21
Branches 35862 35861 -1
==========================================
- Hits 161787 161750 -37
Misses 15233 15233
- Partials 6744 6760 +16
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's set
zlib.bytesReadto end-of-life which has been runtime deprecated since v11.cc @nodejs/tsc