-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: remove --no-experimental-global-customevent flag #52723
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
daeyeon:main.customevt-240427.Sat.c33b
Apr 29, 2024
Merged
cli: remove --no-experimental-global-customevent flag #52723
nodejs-github-bot
merged 2 commits into
nodejs:main
from
daeyeon:main.customevt-240427.Sat.c33b
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
labels
Apr 27, 2024
daeyeon
added
semver-major
PRs that contain breaking changes and should be released in the next major version.
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
c++
Issues and PRs that require attention from people who are familiar with C++.
process
Issues and PRs related to the process subsystem.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
and removed
c++
Issues and PRs that require attention from people who are familiar with C++.
process
Issues and PRs related to the process subsystem.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Apr 27, 2024
Signed-off-by: Daeyeon Jeong <[email protected]>
Signed-off-by: Daeyeon Jeong <[email protected]>
daeyeon
force-pushed
the
main.customevt-240427.Sat.c33b
branch
from
April 27, 2024 15:15
419cea9
to
aee1577
Compare
jasnell
approved these changes
Apr 27, 2024
benjamingr
approved these changes
Apr 27, 2024
panva
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
and removed
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
labels
Apr 27, 2024
panva
approved these changes
Apr 27, 2024
VoltrexKeyva
approved these changes
Apr 27, 2024
mcollina
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
panva
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Apr 27, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
atlowChemi
approved these changes
Apr 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
MoLow
approved these changes
Apr 28, 2024
anonrig
approved these changes
Apr 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mcollina
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 29, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 29, 2024
Landed in f7e73cd |
aduh95
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #52723 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#52723 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#52723 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: nodejs#52723 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
semver-major
PRs that contain breaking changes and should be released in the next major version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
--no-experimental-global-customevent
flag as a follow-up for #52618.Signed-off-by: Daeyeon Jeong [email protected]