Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update amaro to 0.1.8 #54520

Merged
merged 1 commit into from
Aug 25, 2024
Merged

deps: update amaro to 0.1.8 #54520

merged 1 commit into from
Aug 25, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of amaro to 0.1.8.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Aug 23, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2024
@marco-ippolito
Copy link
Member

this update, adds the correct default configuration https://github.com/nodejs/node/pull/54520/files#diff-2eb38b7205bf0f3655deb5fd6ce17d625dce1cfe78d204d16c89a67f35c146e6R492-R499

@marco-ippolito marco-ippolito mentioned this pull request Aug 23, 2024
Closed
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61370/

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (628469c) to head (abef85f).
Report is 318 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54520   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         649      649           
  Lines      182576   182576           
  Branches    35036    35041    +5     
=======================================
+ Hits       159467   159471    +4     
+ Misses      16381    16379    -2     
+ Partials     6728     6726    -2

see 32 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61371/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2024
@marco-ippolito marco-ippolito mentioned this pull request Aug 24, 2024
Closed
@ovflowd
Copy link
Member

ovflowd commented Aug 24, 2024

@marco-ippolito do you feel like fast-tracking this PR is necessary?

@marco-ippolito
Copy link
Member

@marco-ippolito do you feel like fast-tracking this PR is necessary?

Its ok Ivr added commit queue

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit c3fe2d6 into main Aug 25, 2024
71 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in c3fe2d6

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-amaro branch August 25, 2024 10:12
louwers pushed a commit to louwers/node that referenced this pull request Aug 25, 2024
@nodejs-github-bot @louwers
deps: update amaro to 0.1.8
d22ea2d 
PR-URL: nodejs#54520
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.1.8
22a37a8 
PR-URL: #54520
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.1.8
290f6ce 
PR-URL: #54520
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@ovflowd ovflowd ovflowd approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @marco-ippolito @ovflowd @benjamingr @RafaelGSS @targos