Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add git node security --cleanup #54381

Merged
merged 1 commit into from
Aug 17, 2024
Merged

doc: add git node security --cleanup #54381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/contributing/security-release-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,9 @@ security announcements for more information.
folder and merging the PR.

* [ ] 2\. **Cleanup:**
* [ ] Close PRs and backports.
* [ ] Close HackerOne reports:
* [ ] `git node security --cleanup`. This command will:
* Close PRs and backports.
* Close HackerOne reports:
Comment on lines +162 to +164
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit that I think simplifies layout without sacrificing clarity. (But it's a nit, so disregard if you disagree!)

Suggested change
* [ ] `git node security --cleanup`. This command will:
* Close PRs and backports.
* Close HackerOne reports:
* [ ] `git node security --cleanup`. This command will close PRs and backports.
It will also close HackerOne reports:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the document is following the approach of:

  • automated command (git node security --something)
  • operation 1 that is automated
  • operation 2 that is automated
  • manual work

So, in case of the automated command fails (as it's still experimental), users need to know which steps to follow exactly.

* Close Resolved
* Request Disclosure
* Request publication of H1 CVE requests
Expand Down
Loading