-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add git node security --cleanup #54381
Conversation
Review requested:
|
* [ ] `git node security --cleanup`. This command will: | ||
* Close PRs and backports. | ||
* Close HackerOne reports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit that I think simplifies layout without sacrificing clarity. (But it's a nit, so disregard if you disagree!)
* [ ] `git node security --cleanup`. This command will: | |
* Close PRs and backports. | |
* Close HackerOne reports: | |
* [ ] `git node security --cleanup`. This command will close PRs and backports. | |
It will also close HackerOne reports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the document is following the approach of:
- automated command (git node security --something)
- operation 1 that is automated
- operation 2 that is automated
- manual work
So, in case of the automated command fails (as it's still experimental), users need to know which steps to follow exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with or without my nit.
Landed in 9e83853 |
PR-URL: #54381 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54381 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Follow up nodejs/node-core-utils#833