tools: remove header from c-ares license #54335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Aug 12, 2024
anonrig
approved these changes
Aug 12, 2024
lpinca
approved these changes
Aug 12, 2024
|
Shouldn't we update the license at the same time? |
The license file hasn't changed. The header was removed from the file, so our script no longer needs to account for it. This change, nor c-ares/c-ares@595cf21 affects the content of the license. |
|
Sorry, I was somehow really confused by the automated update ^^ |
targos
approved these changes
Aug 14, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 53c5322 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54335 Refs: c-ares/c-ares@595cf21 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: c-ares/c-ares@595cf21