Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: run license-builder #54322

Closed
wants to merge 1 commit into from
Closed

doc: run license-builder #54322

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Aug 12, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

targos
targos approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c-ares/c-ares@595cf21

richardlau
richardlau previously approved these changes Aug 12, 2024
View reviewed changes
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@RedYetiDev RedYetiDev removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@RedYetiDev
Copy link
Member

Hey, just wanted to point out that the license builder script accounted for the header, so if this lands, the license wouldn't match that of c-ares.

The script should be updated instead of landing this IMO.

@RedYetiDev RedYetiDev added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@RedYetiDev
Copy link
Member

I suggest not landing this, and instead landing #54335

@richardlau richardlau removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@richardlau richardlau dismissed their stale review August 12, 2024 15:12

Would prefer to land #54335

@targos targos closed this Aug 13, 2024
@targos targos deleted the actions/license-builder branch August 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@aymen94 aymen94 aymen94 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@richardlau richardlau richardlau left review comments

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @RedYetiDev @targos @richardlau @aymen94 @marco-ippolito