Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: remove outdated comment #54146

Closed
wants to merge 1 commit into from
Closed

test_runner: remove outdated comment #54146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lib/test/mock_loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ const { createRequire, isBuiltin } = require('module');
// https://github.com/nodejs/node/issues/49472
// or https://github.com/nodejs/node/issues/52219

// TODO(cjihrig): Network imports should be supported. There are two current
// hurdles:
// - The module format returned by the load() hook is not known. This could be
// implemented as an option, or default to 'module' for network imports.
// - The generated mock module imports 'node:test', which is not allowed by
// checkIfDisallowedImport() in the ESM code.

const mocks = new SafeMap();

async function initialize(data) {
Expand Down
Loading