test_runner: remove outdated comment #54146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network imports were removed, so remove the comment. Refs: #53822
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jul 31, 2024
jakecastelli
approved these changes
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54146 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 643 643
Lines 181576 181576
Branches 34894 34893 -1
=======================================
+ Hits 158088 158097 +9
- Misses 16759 16767 +8
+ Partials 6729 6712 -17 |
trivikr
approved these changes
Aug 1, 2024
MoLow
approved these changes
Aug 2, 2024
github-actions
bot
removed
the
request-ci
jakecastelli
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54146 ✔ Done loading data for nodejs/node/pull/54146 ----------------------------------- PR info ------------------------------------ Title test_runner: remove outdated comment (#54146) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:cjihrig-patch-1 -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test_runner: remove outdated comment Committers 1 - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54146 Refs: https://github.com/nodejs/node/pull/53822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54146 Refs: https://github.com/nodejs/node/pull/53822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 Jul 2024 13:53:44 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54146#pullrequestreview-2210350629 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54146#pullrequestreview-2210360631 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54146#pullrequestreview-2211473448 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54146#pullrequestreview-2214829569 ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-08-04T12:07:04Z: https://ci.nodejs.org/job/node-test-pull-request/60864/ - Querying data for job/node-test-pull-request/60864/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10237109237 |
jakecastelli
pushed a commit
that referenced
this pull request
Aug 5, 2024
Network imports were removed, so remove the comment. Refs: #53822 PR-URL: #54146 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
|
Landed in ca2ed88 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
Network imports were removed, so remove the comment. Refs: #53822 PR-URL: #54146 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network imports were removed, so remove the comment.
Refs: #53822