-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix c-ares update script #53414
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/fix-c-ares-script
Jun 13, 2024
Merged
tools: fix c-ares update script #53414
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/fix-c-ares-script
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
marco-ippolito
force-pushed
the
feat/fix-c-ares-script
branch
2 times, most recently
from
June 11, 2024 07:42
22fc5a7
to
64248a8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
marco-ippolito
force-pushed
the
feat/fix-c-ares-script
branch
from
June 11, 2024 08:29
64248a8
to
7edcb34
Compare
marco-ippolito
changed the title
tools: fixed c-ares update script
tools: fix c-ares update script
Jun 11, 2024
richardlau
approved these changes
Jun 11, 2024
RafaelGSS
approved these changes
Jun 11, 2024
lpinca
approved these changes
Jun 11, 2024
marco-ippolito
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jun 12, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 13, 2024
Landed in c64a00a |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53414 Fixes: #53407 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53414 Fixes: nodejs#53407 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53414 Fixes: nodejs#53407 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
added a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53414 Fixes: #53407 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
added a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53414 Fixes: #53407 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53407
Successful run https://github.com/nodejs/node/actions/runs/9461669085/job/26062910343
PR created: #53416