Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-ares update script broken by c-ares 1.30.0 #53407

Closed
targos opened this issue Jun 10, 2024 · 1 comment · Fixed by #53414
Closed

c-ares update script broken by c-ares 1.30.0 #53407

targos opened this issue Jun 10, 2024 · 1 comment · Fixed by #53414
Labels
tools Issues and PRs related to the tools directory.

Comments

@marco-ippolito marco-ippolito added the tools Issues and PRs related to the tools directory. label Jun 10, 2024
@richardlau
Copy link
Member

richardlau commented Jun 10, 2024

The tag names have changed. They used to be of the form:

i.e. prefixed with cares- and the numerical parts of the version separated with _.
For c-ares 1.30.0 the tag is v1.30.0. Assuming the tags now follow this format we could update the update script to drop the leading v (and the replacement of _ with . is no longer necessary) as a quick fix.

The correct thing to do is probably to parse the assets out of https://api.github.com/repos/c-ares/c-ares/releases/latest instead of just the tag_name which would give the actual URLs without the update script having to make assumptions as to the format of the download URL (for example, the download URL contains the leading v for the tag).

nodejs-github-bot pushed a commit that referenced this issue Jun 13, 2024
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this issue Jun 20, 2024
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this issue Jun 20, 2024
PR-URL: nodejs#53414
Fixes: nodejs#53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
PR-URL: nodejs#53414
Fixes: nodejs#53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito added a commit that referenced this issue Jul 19, 2024
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito added a commit that referenced this issue Jul 19, 2024
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants