Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update repo docs to use 'CTC' #5304

Closed
wants to merge 1 commit into from

Conversation

orangemocha
Copy link
Contributor

No description provided.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 18, 2016

LGTM

@Fishrock123
Copy link
Contributor

Rubber-stamp LGTM

@@ -1,11 +1,11 @@
# Node.js Working Groups

Node.js Working Groups are autonomous projects created by the
[Technical Steering Committee (TSC)](https://github.com/nodejs/node/blob/master/GOVERNANCE.md#technical-committee).
[Core Technical Committee (CTC)](https://github.com/nodejs/node/blob/master/GOVERNANCE.md#core-technical-committee).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, if I understand correctly CTC is purely a technical body. So this should be TSC only I guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm right, more language needs to be updated. Technically it is the CTC that charters WG's to work on core, but this probably is still outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, it doesn't contemplate that WGs can be created at the TSC level too? How about if we renamed this section to "Node.js Core Working Groups"? Not sure if we need to mention here that there is a level above Core (TSC and TSC chartered WGs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Node.js Core Working Groups"?

That could work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have non-core work groups right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There exist non-core Working Groups in the Node.js Foundation, which report to the TSC. There can also be other working groups that report to other Top Level Projects (e.g. Express or libuv).
I don't think it's strictly necessary for this doc to describe the whole hierarchy, and things that it doesn't have a governance over, though it could certainly be improved (perhaps with a link). Maybe room for another PR? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks for clarifying :)

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Feb 18, 2016
@orangemocha
Copy link
Contributor Author

Updated WORKING_GROUPS.md to refer to working groups as "Node.js Core Working Groups" in the title and first sentence of the doc.

@orangemocha
Copy link
Contributor Author

FYI @nodejs/ctc

@jasnell
Copy link
Member

jasnell commented Feb 19, 2016

Lgtm

orangemocha added a commit that referenced this pull request Feb 22, 2016
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@orangemocha
Copy link
Contributor Author

Landed with 18abb3c. Thank you.

rvagg pushed a commit that referenced this pull request Feb 23, 2016
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5304
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants