Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

doc: contribution guidelines for node-chakracore #27

Open
wants to merge 1 commit into
base: chakracore-master
Choose a base branch
from

Conversation

orangemocha
Copy link
Contributor

Tweak docs to clarify the contribution guidelines for the node-chakracore
repo.
These changes are specific to node-chakracore and should never be
backported to nodejs/node.

Ref: #18

Tweak docs to clarify the contribution guidelines for the node-chakracore
repo.
These changes are specific to node-chakracore and should never be
backported to nodejs/node.

Ref: nodejs#18
Collaborators and TC members.
All modifications to the Node.js on ChakraCore code and documentation
should be performed via GitHub pull requests, including modifications
by Collaborators and TC members.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in the upstream. Rather than fix it here, I'll open a PR upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orangemocha
Copy link
Contributor Author

Question for @nodejs/node-chakracore : do we think that the 48/72 hour requirement for landing PRs is still appropriate in this repo?

Before landing pull requests, sufficient time should be left for input from other Collaborators. Leave at least 48 hours during the week and 72 hours over weekends to account for international time differences and work schedules. Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other wide-reaching impact) may be landed after a shorter delay.

@aruneshchandra
Copy link
Contributor

Yes - I think it appropriate for this repo as well. There is no reason for us to deviate from the mainline policy on this.

@thefourtheye
Copy link
Contributor

I also agree with @aruneshchandra. We already have people working in different timezones. So this will really give us a chance to get opinion from most of us.

@joaocgreis
Copy link
Member

This could be merged to a branch specific for changes that would not outlive this repository, leaving chakracore-master with only changes to be pulled to node.

What about creating a branch named something like chakracore-docs, including the README changes we already have and making it the default branch, so the README would show? Perhaps delete everything else, that will get outdated by the chakracore-master branch.

@orangemocha
Copy link
Contributor Author

That would be the cleaner option to separate doc changes but the downside is that the default branch shown on github is also the default branch checked out after a git clone.

The default branch is considered the “base” branch in your repository, against which all pull requests and code commits are automatically made, unless you specify a different branch.

The best idea I could come up with is this label dont-backport-to-node. Note that some changes to the readme have already landed in a commit that included source code changes that should be backported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants