tools: update ESLint to version 2.1.0 #5214

Trott · 2016-02-13T06:19:36Z

Update ESLint to 2.1.0. ESLint has a number of potentially-useful new
features but this change attempts to be minimal in its changes.
However, some things could not be avoided reasonably.

ESLint 2.1.0 found a few lint issues that ESLint 1.x missed, particularly
around template strings that did not take advantage of any features of
template strings, and let declarations where const sufficed.

Additionally, ESLint 2.1.0 removes some granularity around enabling ES6
features. Some features (e.g., spread operator) that had been turned off
in our configuration for ESLint 1.x are now permitted.

Trott · 2016-02-13T06:33:16Z

I hate to re-open the whole "OH NOES SHOULD WE ENABLE ES6-EVERYTHING OR NOT?!?!" question. But maybe it's easier to come to consensus if it's a "Eh, we've gotta upgrade to ESLint 2.0 sooner or later, and sooner is probably better, so..."

To hopefully clarify a bit: ESLint 2 appears to remove options that allow enabling picking and choosing your ES6 features. You can't say "Arrow functions are OK, but NO SPREAD OPERATORS!!!!" Well, you can, but it probably involves writing a custom rule. (The exception is ES6 modules which are turned off unless you take an extra step to turn them on.) This was something that ~~(I think) @targos~~ @cjihrig warned was coming in some of the previous threads about whether we should continue to granularly manage ES6 features in the lint config (and, if so, whether it should be deny-all-with-exceptions or allow-all-with-disallowed-list).

On the upside, ESLint 2 seems to have found some stuff missed by ESLint 1. And it has some features we might want. Interested parties can review new rules available at http://eslint.org/blog/2016/02/eslint-v2.0.0-released#new-rules.

silverwind · 2016-02-13T12:10:02Z

~~Don't we need to update the removed rules?~~

silverwind · 2016-02-13T12:17:51Z

Nevermind, I see you made that change in the seond commit. I'd suggest moving config changes to its own commit.

cjihrig · 2016-02-13T14:54:51Z

ESLint 2 appears to remove options that allow enabling picking and choosing your ES6 features.

@rvagg this is what I was talking about in #5052.

Trott · 2016-02-13T22:08:29Z

@silverwind I put the .eslintrc changes into their own commits (6e3f278 and af3a3c6). It had to be two commits rather than one. The first commit removes rules that will break when ESLint 2 is running. That commit happens before the commit that updates ESLint 1 to ESLint 2. After the update, another commit reinstates the old behavior using the new rules. Doing all the changes to .eslintrc in its own commit (without any simultaneous changes to tools/eslint) would mean that there would be a commit somewhere that would be a broken build.

Trott · 2016-02-13T22:17:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/1654/

silverwind · 2016-02-14T04:33:10Z

Thanks! I'm fine with two commits there.

I think we need ecmaVersion: 6 in parserOptions. As I understand it, env: es6 only gives us the globals.

Trott · 2016-02-14T04:42:12Z

@silverwind According to the docs, specifying es6 as an env enables all ES6 features except modules. So I don't think we need to use parserOptions too (although I suppose it wouldn't cause problems either). The lint results seem to bear that out.

silverwind · 2016-02-14T04:56:05Z

Ah, your're right, the parser option is set by the env:

https://github.com/eslint/eslint/blob/5aa474833b161b2d5eb684b911d1f7745fa2a696/conf/environments.js#L99-L103

silverwind · 2016-02-14T04:56:57Z

LGTM

targos · 2016-02-15T07:21:19Z

When I updated to v1, I used dmn to reduce the number of files. Could you do the same ?
FWIW here is the full procedure I followed: https://gist.github.com/targos/f2de3a723a4ec54290ee

targos · 2016-02-15T07:29:30Z

Can you please make sure that the tools: update ESLint to version 2.0 commit is only about the changes tools/eslint ? I see some in tools/doc and tools/eslint-rules.

Trott · 2016-02-15T15:36:58Z

@targos wrote:

Can you please make sure that the tools: update ESLint to version 2.0 commit is only about the changes tools/eslint ? I see some in tools/doc and tools/eslint-rules.

Ugh, yes, that was a mistake. I'll fix that.

Trott · 2016-02-15T15:38:24Z

@targos wrote:

When I updated to v1, I used dmn to reduce the number of files. Could you do the same ?

Oh, yes, definitely! I did not know about dmn.

jasnell · 2016-02-15T15:56:07Z

LGTM

Trott · 2016-02-15T16:12:59Z

@targos The reworking of the commits and using dmn are all done now. Thanks! (The gist was really helpful, unsurprisingly.)

Trott · 2016-02-15T16:14:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/1664/

MylesBorins · 2016-02-15T19:06:26Z

Looks like eslint has updated to v2.1.0 already. Might want to bump it in this PR

ESLint 2.1.0 is coming. Some lint rules have been tightened. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules that will not exist in ESLint 2. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint 2 equivalents. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

ESLint 2.1.0 is coming. Some lint rules have been tightened. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules that will not exist in ESLint 2. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint 2 equivalents. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes security updates to openssl. More information can be found [on nodejs.org](https://nodejs.org/en/blog/vulnerability/openssl-march-2016/) This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) #3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) #4482 * src: - Better support for Big-Endian systems (Bryon Leung) #3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) #2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) #4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) #4841 * https: - A potential fix for #3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) #4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) #3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) #5510 * *openssl: - upgrade openssl to 1.0.2g (Ben Noordhuis) #5507 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) #4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) #4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) #4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) #5214 PR-URL: #5301

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes security updates to openssl. More information can be found [on nodejs.org](https://nodejs.org/en/blog/vulnerability/openssl-march-2016/) This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) nodejs#3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) nodejs#4482 * src: - Better support for Big-Endian systems (Bryon Leung) nodejs#3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) nodejs#2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) nodejs#4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) nodejs#4841 * https: - A potential fix for nodejs#3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) nodejs#4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) nodejs#3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) nodejs#5510 * *openssl: - upgrade openssl to 1.0.2g (Ben Noordhuis) nodejs#5507 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) nodejs#4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) nodejs#4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) nodejs#4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) nodejs#5214 PR-URL: nodejs#5301

ESLint 2.1.0 is coming. Some lint rules have been tightened. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules that will not exist in ESLint 2. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Update ESLint to 2.1.0. ESLint has a number of potentially-useful new features but this change attempts to be minimal in its changes. However, some things could not be avoided reasonably. ESLint 2.1.0 found a few lint issues that ESLing 1.x missed with template strings that did not take advantage of any features of template strings, and `let` declarations where `const` sufficed. Additionally, ESLint 2.1.0 removes some granularity around enabling ES6 features. Some features (e.g., spread operator) that had been turned off in our configuration for ESLint 1.x are now permitted. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Now that we are using ESLint 2, replace ESLint 1 rules with their ESLint 2 equivalents. PR-URL: #5214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Myles Borins <[email protected]>

In December we announced that we would be doing a minor release in order to get a number of voted on SEMVER-MINOR changes into LTS. Our ability to release this was delayed due to the unforeseen security release v4.3. We are quickly bumping to v4.4 in order to bring you the features that we had committed to releasing. This release also includes over 70 fixes to our docs and over 50 fixes to tests. The SEMVER-MINOR changes include: * deps: - An update to v8 that introduces a new flag --perf_basic_prof_only_functions (Ali Ijaz Sheikh) #3609 * http: - A new feature in http(s) agent that catches errors on *keep alived* connections (José F. Romaniello) #4482 * src: - Better support for Big-Endian systems (Bryon Leung) #3410 * tls: - A new feature that allows you to pass common SSL options to `tls.createSecurePair` (Коренберг Марк) #2441 * tools - a new flag `--prof-process` which will execute the tick processor on the provided isolate files (Matt Loring) #4021 Notable semver patch changes include: * buld: - Support python path that includes spaces. This should be of particular interest to our Windows users who may have python living in `c:/Program Files` (Felix Becker) #4841 * https: - A potential fix for #3692 HTTP/HTTPS client requests throwing EPROTO (Fedor Indutny) #4982 * installer: - More readable profiling information from isolate tick logs (Matt Loring) #3032 * *npm: - upgrade to npm 2.14.20 (Kat Marchán) #5510 * process: - Add support for symbols in event emitters. Symbols didn't exist when it was written ¯\_(ツ)_/¯ (cjihrig) #4798 * querystring: - querystring.parse() is now 13-22% faster! (Brian White) #4675 * streams: - performance improvements for moving small buffers that shows a 5% throughput gain. IoT projects have been seen to be as much as 10% faster with this change! (Matteo Collina) #4354 * tools: - eslint has been updated to version 2.1.0 (Rich Trott) #5214 PR-URL: #5301

Trott added tools Issues and PRs related to the tools directory. lts-watch-v4.x labels Feb 13, 2016

Trott force-pushed the eslint2 branch from 6bc45f6 to af3a3c6 Compare February 13, 2016 22:03

Trott force-pushed the eslint2 branch from af3a3c6 to 5fe022b Compare February 15, 2016 16:12

Trott force-pushed the eslint2 branch from 5fe022b to 3f886d2 Compare February 15, 2016 22:42

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Mar 1, 2016

MylesBorins mentioned this pull request Mar 1, 2016

V4.4.0 proposal #5301

Merged

Trott deleted the eslint2 branch October 10, 2021 01:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update ESLint to version 2.1.0 #5214

tools: update ESLint to version 2.1.0 #5214

Trott commented Feb 13, 2016

Trott commented Feb 13, 2016

silverwind commented Feb 13, 2016

silverwind commented Feb 13, 2016

cjihrig commented Feb 13, 2016

Trott commented Feb 13, 2016

Trott commented Feb 13, 2016

silverwind commented Feb 14, 2016

Trott commented Feb 14, 2016

silverwind commented Feb 14, 2016

silverwind commented Feb 14, 2016

targos commented Feb 15, 2016

targos commented Feb 15, 2016

Trott commented Feb 15, 2016

Trott commented Feb 15, 2016

jasnell commented Feb 15, 2016

Trott commented Feb 15, 2016

Trott commented Feb 15, 2016

MylesBorins commented Feb 15, 2016

tools: update ESLint to version 2.1.0 #5214

tools: update ESLint to version 2.1.0 #5214

Conversation

Trott commented Feb 13, 2016

Trott commented Feb 13, 2016

silverwind commented Feb 13, 2016

silverwind commented Feb 13, 2016

cjihrig commented Feb 13, 2016

Trott commented Feb 13, 2016

Trott commented Feb 13, 2016

silverwind commented Feb 14, 2016

Trott commented Feb 14, 2016

silverwind commented Feb 14, 2016

silverwind commented Feb 14, 2016

targos commented Feb 15, 2016

targos commented Feb 15, 2016

Trott commented Feb 15, 2016

Trott commented Feb 15, 2016

jasnell commented Feb 15, 2016

Trott commented Feb 15, 2016

Trott commented Feb 15, 2016

MylesBorins commented Feb 15, 2016