Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 10.2.2 #50493

Closed
wants to merge 1 commit into from
Closed

Conversation

npm-cli-bot
Copy link
Contributor

This PR contains changes from: [email protected] [email protected]

This PR replaces: nodejs/node#50258


10.2.1

10.2.1 (2023-10-18)

Bug Fixes

Documentation

Dependencies

10.2.2

10.2.2 (2023-10-31)

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Oct 31, 2023
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@lukekarrys lukekarrys added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@lukekarrys lukekarrys added backported-to-v18.x PRs backported to the v18.x-staging branch. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. and removed backported-to-v18.x PRs backported to the v18.x-staging branch. labels Oct 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

@lukekarrys lukekarrys removed the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Oct 31, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

The AIX failure looks like it might be a regression in [email protected]:
e.g. https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-ppc64/48919/console

06:47:36 gyp ERR! stack TypeError: findAccessibleSync is not a function
06:47:36 gyp ERR! stack at runGyp (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:153:21)
06:47:36 gyp ERR! stack at findConfigs (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:85:14)
06:47:36 gyp ERR! stack at findConfigs (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/lib/configure.js:101:12)
06:47:36 gyp ERR! stack at async run (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/bin/node-gyp.js:81:18)
06:47:36 gyp ERR! System AIX 7.2
06:47:36 gyp ERR! command "/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/node" "/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/deps/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--directory=/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/benchmark/napi/define_properties"

@wraithgar
Copy link

wraithgar commented Nov 2, 2023

That method got moved in this commit and it's likely a test mock didn't get updated doesn't look like mocks are the culprit, but that commit likely is.

@richardlau
Copy link
Member

That method got moved in this commit and it's likely a test mock didn't get updated doesn't look like mocks are the culprit, but that commit likely is.

I think nodejs/node-gyp#2936 should fix it.

@npm-cli-bot
Copy link
Contributor Author

Closing in favor of #50531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants