Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local util for findAccessibleSync() #2936

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Nov 2, 2023

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

The findAccessibleSync() function is in the local util module instead of Node.js' builtin util module.

Refs: nodejs/node#50493 (comment)


Existing tests should cover this, but only on AIX or z/OS, neither of which are available on GitHub Actions (and neither of those OSes are a supported platform for running a self-hosted runner).

The `findAccessibleSync()` function is in the local `util` module
instead of Node.js' builtin `util` module.
@richardlau
Copy link
Member Author

richardlau commented Nov 2, 2023

Took me a while to figure out how to get citgm-smoker-nobuild to run with this PR[1]:

[1]: I had to use

citgm --sha 4c110b952222501b677585e230932b140767168f node-gyp

for some reason citgm fails to find tests if run with

citgm richardlau/node-gyp#aix

@wraithgar
Copy link
Contributor

You've got good eyes, I did NOT see the ./ there.

@richardlau
Copy link
Member Author

You've got good eyes, I did NOT see the ./ there.

That's because it was missing 😆.

@lukekarrys lukekarrys merged commit b39e681 into nodejs:main Nov 2, 2023
34 of 35 checks passed
@richardlau richardlau deleted the aix branch November 2, 2023 16:15
@lukekarrys
Copy link
Member

Thank you @richardlau! I've published [email protected] and will release it in [email protected] and get a new Node.js PR open as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants