Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable no-redeclare rule for linter #5047

Closed
wants to merge 2 commits into from
Closed

tools: enable no-redeclare rule for linter #5047

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 3, 2016

At long last, no-redeclare is ready to be enabled.

@Trott Trott added tools Issues and PRs related to the tools directory. lts-watch-v4.x labels Feb 3, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

LGTM 🎆

@Trott
Copy link
Member Author

Trott commented Feb 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1520/

@jasnell
Copy link
Member

jasnell commented Feb 3, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 3, 2016

CI was all green except for one host that hung while building. Trying again:

https://ci.nodejs.org/job/node-test-pull-request/1521/

@silverwind
Copy link
Contributor

LGTM 🎉

@targos
Copy link
Member

targos commented Feb 3, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
@Trott @jasnell
tools: fix redeclared vars in doc/json.js
c14c12e 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Feb 4, 2016
@Trott @jasnell
tools: enable no-redeclare rule for linter
34f3967 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

Landed in c14c12e and 34f3967

@jasnell jasnell closed this Feb 4, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
tools: fix redeclared vars in doc/json.js
7fa5959 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
rvagg pushed a commit that referenced this pull request Feb 10, 2016
@Trott @rvagg
tools: enable no-redeclare rule for linter
5c54d49 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott mentioned this pull request Feb 16, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
tools: fix redeclared vars in doc/json.js
92abd29 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
tools: enable no-redeclare rule for linter
d462550 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
tools: fix redeclared vars in doc/json.js
1dae175 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
tools: enable no-redeclare rule for linter
6345acb 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
tools: fix redeclared vars in doc/json.js
9cd623f 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
tools: enable no-redeclare rule for linter
4b09dc5 
PR-URL: #5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
tools: fix redeclared vars in doc/json.js
f7f9917 
PR-URL: nodejs#5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
tools: enable no-redeclare rule for linter
a5f6593 
PR-URL: nodejs#5047
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the no-redeclare branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @cjihrig @jasnell @silverwind @targos @MylesBorins