Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use primordials for navigator.userAgent #50467

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 29, 2023

@anonrig
@ljharb

I got the PR comment, that we should use primordials for userAgent by ljharb As that line was not touched by my PR I want to mark it as resolved, but not lose the information. So here I provide the corresponding PR and resolve that remark in my PR ;)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2023
@GeoffreyBooth GeoffreyBooth added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get answer to my questions before merging this PR

lib/internal/navigator.js Show resolved Hide resolved
@anonrig anonrig removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2023
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a constant that might as well be constructed before any user code runs, but LGTM either way.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 30, 2023

What is the conclusion? :)
Can somebody please retrigger the failing ci?

@anonrig
Copy link
Member

anonrig commented Oct 30, 2023

What is the conclusion? :) Can somebody please retrigger the failing ci?

I've left a comment: #50467 (comment)

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 1, 2023

Can somebody please have a look if the CI issues are unrelated and maybe merge?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 2, 2023

@GeoffreyBooth
I think the failing tests are unrelated. Should I rebase from main?

@nodejs-github-bot
Copy link
Collaborator

@GeoffreyBooth
Copy link
Member

Don't rebase unless you have to, we won't be able to resume CI once you do that.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 2, 2023

Seems that the CI is green.

Can somebody add the author-ready label and/or merge it?

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 45f5c9b into nodejs:main Nov 2, 2023
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 45f5c9b

@Uzlopak Uzlopak deleted the primordials-useragent branch November 2, 2023 13:33
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
PR-URL: nodejs#50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.